Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-1925

SafeModeInfo should use DFS_NAMENODE_SAFEMODE_THRESHOLD_PCT_DEFAULT instead of 0.95

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.22.0
    • Component/s: None
    • Labels:
    • Hadoop Flags:
      Reviewed

      Description

      SafeMode() constructor has 0.95f default threshold hard-coded. This should be replaced by the constant DFS_NAMENODE_SAFEMODE_THRESHOLD_PCT_DEFAULT, which is correctly set to 0.999f.

      1. HDFS-1925-1.patch
        5 kB
        Joey Echeverria

        Activity

        Hide
        Joey Echeverria added a comment -

        If no one else is working on this, I'll take a stab at it.

        Show
        Joey Echeverria added a comment - If no one else is working on this, I'll take a stab at it.
        Hide
        Joey Echeverria added a comment -

        Here's my first official patch!

        Show
        Joey Echeverria added a comment - Here's my first official patch!
        Hide
        Todd Lipcon added a comment -

        I'm impressed by the valiant effort to make a regression test, but I think the test itself is too fragile for what's essentially a code cleanup. +1 on the fix but -1 on the test Assuming the test-patch comes back clean I'll commit just the fix part.

        Show
        Todd Lipcon added a comment - I'm impressed by the valiant effort to make a regression test, but I think the test itself is too fragile for what's essentially a code cleanup. +1 on the fix but -1 on the test Assuming the test-patch comes back clean I'll commit just the fix part.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12479655/HDFS-1925-1.patch
        against trunk revision 1124364.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 2 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these core unit tests:
        org.apache.hadoop.hdfs.TestDFSStorageStateRecovery
        org.apache.hadoop.hdfs.TestFileConcurrentReader
        org.apache.hadoop.hdfs.TestInjectionForSimulatedStorage
        org.apache.hadoop.tools.TestJMXGet

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/563//testReport/
        Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/563//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/563//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12479655/HDFS-1925-1.patch against trunk revision 1124364. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.hdfs.TestDFSStorageStateRecovery org.apache.hadoop.hdfs.TestFileConcurrentReader org.apache.hadoop.hdfs.TestInjectionForSimulatedStorage org.apache.hadoop.tools.TestJMXGet +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/563//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/563//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/563//console This message is automatically generated.
        Hide
        Todd Lipcon added a comment -

        Committed to 22 and trunk. Thanks, Joey

        Show
        Todd Lipcon added a comment - Committed to 22 and trunk. Thanks, Joey
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #677 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/677/)

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #677 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/677/ )
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-22-branch #53 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-22-branch/53/)

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-22-branch #53 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-22-branch/53/ )
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #673 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/673/)

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #673 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/673/ )

          People

          • Assignee:
            Joey Echeverria
            Reporter:
            Konstantin Shvachko
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development