Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-1906

Remove logging exception stack trace when one of the datanode targets to read from is not reachable

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.20.203.1
    • Fix Version/s: 0.23.0
    • Component/s: hdfs-client
    • Labels:
      None

      Description

      When client fails to connect to one of the datanodes from the list of block locations returned, exception stack trace is printed in the client log. This is an expected failure scenario that is handled at the client, by going to the next location. Printing entire stack trace is unnecessary and just printing the exception message should be sufficient.

      1. HDFS-1906.patch
        1 kB
        Suresh Srinivas
      2. HDFS-1906.2.patch
        1 kB
        Suresh Srinivas
      3. HDFS-1906.rel205.patch
        2 kB
        Suresh Srinivas

        Activity

        Hide
        Eli Collins added a comment -

        +1 lgtm

        Show
        Eli Collins added a comment - +1 lgtm
        Hide
        Tsz Wo Nicholas Sze added a comment -

        I think the stack trace is useful for debug. How about printing it if debug is enabled?

        Show
        Tsz Wo Nicholas Sze added a comment - I think the stack trace is useful for debug. How about printing it if debug is enabled?
        Hide
        Suresh Srinivas added a comment -

        Updated patch prints exception stack trace in debug logs.

        Show
        Suresh Srinivas added a comment - Updated patch prints exception stack trace in debug logs.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        +1 patch looks good.

        Show
        Tsz Wo Nicholas Sze added a comment - +1 patch looks good.
        Hide
        Suresh Srinivas added a comment -

        No tests are added in this patch, because this is a simple log change. I am also not planning to run hudson tests.

        Show
        Suresh Srinivas added a comment - No tests are added in this patch, because this is a simple log change. I am also not planning to run hudson tests.
        Hide
        Suresh Srinivas added a comment -

        I committed the patch.

        Show
        Suresh Srinivas added a comment - I committed the patch.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #637 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/637/)

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #637 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/637/ )
        Hide
        Suresh Srinivas added a comment -

        Patch for 0.20.205

        Show
        Suresh Srinivas added a comment - Patch for 0.20.205
        Hide
        Tsz Wo Nicholas Sze added a comment -

        > Patch for 0.20.205
        +1

        Show
        Tsz Wo Nicholas Sze added a comment - > Patch for 0.20.205 +1
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #673 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/673/)

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #673 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/673/ )

          People

          • Assignee:
            Suresh Srinivas
            Reporter:
            Suresh Srinivas
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development