Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-1890

A few improvements on the LeaseRenewer.pendingCreates map

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.23.0
    • Component/s: hdfs-client
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      • The class is better to be just a Map instead of a SortedMap.
      • The value type is better to be DFSOutputStream instead of OutputStream.
      • The variable name is better to be filesBeingWritten instead of pendingCreates since we have append.
      1. h1890_20110504c.patch
        6 kB
        Tsz Wo Nicholas Sze
      2. h1890_20110504b.patch
        7 kB
        Tsz Wo Nicholas Sze
      3. h1890_20110504.patch
        6 kB
        Tsz Wo Nicholas Sze

        Activity

        Hide
        Tsz Wo Nicholas Sze added a comment -

        h1890_20110504.patch: see description.

        Show
        Tsz Wo Nicholas Sze added a comment - h1890_20110504.patch: see description.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        h1890_20110504b.patch: fixed some warnings.

        Show
        Tsz Wo Nicholas Sze added a comment - h1890_20110504b.patch: fixed some warnings.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        h1890_20110504c.patch: oops, cannot remove the @SuppressWarnings tags in DistributedFileSystem.

        Show
        Tsz Wo Nicholas Sze added a comment - h1890_20110504c.patch: oops, cannot remove the @SuppressWarnings tags in DistributedFileSystem .
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12478212/h1890_20110504c.patch
        against trunk revision 1099525.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these core unit tests:
        org.apache.hadoop.hdfs.server.namenode.TestBackupNode
        org.apache.hadoop.hdfs.TestDFSStorageStateRecovery
        org.apache.hadoop.hdfs.TestFileConcurrentReader

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/455//testReport/
        Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/455//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/455//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12478212/h1890_20110504c.patch against trunk revision 1099525. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.hdfs.server.namenode.TestBackupNode org.apache.hadoop.hdfs.TestDFSStorageStateRecovery org.apache.hadoop.hdfs.TestFileConcurrentReader +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/455//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/455//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/455//console This message is automatically generated.
        Hide
        Tanping Wang added a comment -

        +1. Patch looks good.

        Show
        Tanping Wang added a comment - +1. Patch looks good.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        Tanping, thanks for the review.

        No new tests added since the changes are obvious. The failed tests are not related to this.

        Show
        Tsz Wo Nicholas Sze added a comment - Tanping, thanks for the review. No new tests added since the changes are obvious. The failed tests are not related to this.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        I have committed this.

        Show
        Tsz Wo Nicholas Sze added a comment - I have committed this.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #673 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/673/)

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #673 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/673/ )

          People

          • Assignee:
            Tsz Wo Nicholas Sze
            Reporter:
            Tsz Wo Nicholas Sze
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development