Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.23.0
    • Component/s: hdfs-client
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Two simply changes:

      • move the inner class LeaseChecker from DFSClient to a separated class;
      • rename LeaseChecker to LeaseRenewer since it is actually renewing lease instead of checking lease.
      1. h1870_20110129.patch
        27 kB
        Tsz Wo Nicholas Sze

        Activity

        Hide
        Tsz Wo Nicholas Sze added a comment -

        h1870_20110129.patch: see description.

        Show
        Tsz Wo Nicholas Sze added a comment - h1870_20110129.patch: see description.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        I have manually submitted to Jenkins for two times but it has not posted any results here.

             [exec] +1 overall.  
             [exec] 
             [exec]     +1 @author.  The patch does not contain any @author tags.
             [exec] 
             [exec]     +1 tests included.  The patch appears to include 12 new or modified tests.
             [exec] 
             [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
             [exec] 
             [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
             [exec] 
             [exec]     +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.
             [exec] 
             [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.
             [exec] 
             [exec]     +1 system test framework.  The patch passed system test framework compile.
        
        Show
        Tsz Wo Nicholas Sze added a comment - I have manually submitted to Jenkins for two times but it has not posted any results here. [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 12 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 system test framework. The patch passed system test framework compile.
        Hide
        John George added a comment -

        +1 Overall the changes look good to me.

        A very very minor comment:
        Line "import org.apache.hadoop.hdfs.protocol.ExtendedBlock;" got removed from 67 and got added to 76...

        Show
        John George added a comment - +1 Overall the changes look good to me. A very very minor comment: Line "import org.apache.hadoop.hdfs.protocol.ExtendedBlock;" got removed from 67 and got added to 76...
        Hide
        Tsz Wo Nicholas Sze added a comment -

        Thanks John for the review. I use Eclipse for fixing the imports so that it sorts the imports alphabetically.

        Show
        Tsz Wo Nicholas Sze added a comment - Thanks John for the review. I use Eclipse for fixing the imports so that it sorts the imports alphabetically.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        I ran tests locally. All passed except for TestDatanodeBlockScanner but the failure is not related to this.

        Testcase: testBlockCorruptionRecoveryPolicy1 took 2.218 sec
        	Caused an ERROR
        Timed out waiting for corrupt replicas. Waiting for 1, but only found 0
        java.util.concurrent.TimeoutException: Timed out waiting for corrupt replicas. Waiting for 1, but only found 0
        	at org.apache.hadoop.hdfs.DFSTestUtil.waitCorruptReplicas(DFSTestUtil.java:308)
        	at org.apache.hadoop.hdfs.TestDatanodeBlockScanner.blockCorruptionRecoveryPolicy(TestDatanodeBlockScanner.java:288)
        	at org.apache.hadoop.hdfs.TestDatanodeBlockScanner.testBlockCorruptionRecoveryPolicy1(TestDatanodeBlockScanner.java:236)
        
        Show
        Tsz Wo Nicholas Sze added a comment - I ran tests locally. All passed except for TestDatanodeBlockScanner but the failure is not related to this. Testcase: testBlockCorruptionRecoveryPolicy1 took 2.218 sec Caused an ERROR Timed out waiting for corrupt replicas. Waiting for 1, but only found 0 java.util.concurrent.TimeoutException: Timed out waiting for corrupt replicas. Waiting for 1, but only found 0 at org.apache.hadoop.hdfs.DFSTestUtil.waitCorruptReplicas(DFSTestUtil.java:308) at org.apache.hadoop.hdfs.TestDatanodeBlockScanner.blockCorruptionRecoveryPolicy(TestDatanodeBlockScanner.java:288) at org.apache.hadoop.hdfs.TestDatanodeBlockScanner.testBlockCorruptionRecoveryPolicy1(TestDatanodeBlockScanner.java:236)
        Hide
        Tsz Wo Nicholas Sze added a comment -

        I have committed this.

        Show
        Tsz Wo Nicholas Sze added a comment - I have committed this.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #673 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/673/)

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #673 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/673/ )

          People

          • Assignee:
            Tsz Wo Nicholas Sze
            Reporter:
            Tsz Wo Nicholas Sze
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development