Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-1785

Cleanup BlockReceiver and DataXceiver

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 0.23.0
    • datanode
    • None
    • Reviewed

    Description

      clientName.length() is used multiple times for determining whether the source is a client or a datanode.

      if (clientName.length() == 0) {
      //it is a datanode
      }
      

      Attachments

        1. h1785_20110324.patch
          13 kB
          Tsz-wo Sze
        2. h1785_20110325.patch
          13 kB
          Tsz-wo Sze

        Issue Links

          Activity

            szetszwo Tsz-wo Sze added a comment -

            h1785_20110324.patch: simple code cleanup

            szetszwo Tsz-wo Sze added a comment - h1785_20110324.patch: simple code cleanup
            hadoopqa Hadoop QA added a comment -

            -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12474592/h1785_20110324.patch
            against trunk revision 1083958.

            +1 @author. The patch does not contain any @author tags.

            -1 tests included. The patch doesn't appear to include any new or modified tests.
            Please justify why no new tests are needed for this patch.
            Also please list what manual steps were performed to verify this patch.

            +1 javadoc. The javadoc tool did not generate any warning messages.

            +1 javac. The applied patch does not increase the total number of javac compiler warnings.

            +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

            +1 release audit. The applied patch does not increase the total number of release audit warnings.

            -1 core tests. The patch failed these core unit tests:
            org.apache.hadoop.cli.TestHDFSCLI
            org.apache.hadoop.hdfs.TestDFSShell
            org.apache.hadoop.hdfs.TestFileConcurrentReader

            -1 contrib tests. The patch failed contrib unit tests.

            +1 system test framework. The patch passed system test framework compile.

            Test results: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/284//testReport/
            Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/284//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
            Console output: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/284//console

            This message is automatically generated.

            hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12474592/h1785_20110324.patch against trunk revision 1083958. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.cli.TestHDFSCLI org.apache.hadoop.hdfs.TestDFSShell org.apache.hadoop.hdfs.TestFileConcurrentReader -1 contrib tests. The patch failed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/284//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/284//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/284//console This message is automatically generated.

            Thanks for cleaning up this code.

            1. Minor: BlockReceiver.java "It is an empty string for datanode ", could be changed to "It is empty if the datanode is the client".

            +1 for the patch.

            sureshms Suresh Srinivas added a comment - Thanks for cleaning up this code. Minor: BlockReceiver.java "It is an empty string for datanode ", could be changed to "It is empty if the datanode is the client". +1 for the patch.
            szetszwo Tsz-wo Sze added a comment -

            Thanks Suresh for the review.

            h1785_20110325.patch: change the comment

            szetszwo Tsz-wo Sze added a comment - Thanks Suresh for the review. h1785_20110325.patch: change the comment
            szetszwo Tsz-wo Sze added a comment -

            I have committed this.

            szetszwo Tsz-wo Sze added a comment - I have committed this.
            hadoopqa Hadoop QA added a comment -

            -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12474643/h1785_20110325.patch
            against trunk revision 1085460.

            +1 @author. The patch does not contain any @author tags.

            -1 tests included. The patch doesn't appear to include any new or modified tests.
            Please justify why no new tests are needed for this patch.
            Also please list what manual steps were performed to verify this patch.

            +1 javadoc. The javadoc tool did not generate any warning messages.

            +1 javac. The applied patch does not increase the total number of javac compiler warnings.

            +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

            +1 release audit. The applied patch does not increase the total number of release audit warnings.

            -1 core tests. The patch failed these core unit tests:
            org.apache.hadoop.cli.TestHDFSCLI
            org.apache.hadoop.hdfs.TestDFSShell
            org.apache.hadoop.hdfs.TestFileConcurrentReader

            -1 contrib tests. The patch failed contrib unit tests.

            +1 system test framework. The patch passed system test framework compile.

            Test results: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/285//testReport/
            Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/285//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
            Console output: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/285//console

            This message is automatically generated.

            hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12474643/h1785_20110325.patch against trunk revision 1085460. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.cli.TestHDFSCLI org.apache.hadoop.hdfs.TestDFSShell org.apache.hadoop.hdfs.TestFileConcurrentReader -1 contrib tests. The patch failed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/285//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/285//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/285//console This message is automatically generated.
            szetszwo Tsz-wo Sze added a comment -

            I forgot to say that the test failures are not related to this.

            See HDFS-1786 for TestHDFSCLI and TestDFSShell.

            szetszwo Tsz-wo Sze added a comment - I forgot to say that the test failures are not related to this. See HDFS-1786 for TestHDFSCLI and TestDFSShell.
            hudson Hudson added a comment -

            Integrated in Hadoop-Hdfs-trunk-Commit #582 (See https://hudson.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/582/)

            hudson Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #582 (See https://hudson.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/582/ )
            hudson Hudson added a comment -

            Integrated in Hadoop-Hdfs-trunk #643 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/643/)

            hudson Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #643 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/643/ )

            People

              szetszwo Tsz-wo Sze
              szetszwo Tsz-wo Sze
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: