Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.23.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      There is a bug in the concat code. Specifically: in INodeFile.appendBlocks() we need to first reassign the blocks list and then go through it and update the INode pointer. Otherwise we are not updating the inode pointer on all of the new blocks in the file.

      1. HDFS-1776-1.patch
        3 kB
        Bharath Mundlapudi

        Issue Links

          Activity

          Dmytro Molkov created issue -
          Rosie Li made changes -
          Field Original Value New Value
          Link This issue is blocked by MAPREDUCE-2257 [ MAPREDUCE-2257 ]
          Bharath Mundlapudi made changes -
          Assignee Bharath Mundlapudi [ bharathm ]
          Bharath Mundlapudi made changes -
          Fix Version/s 0.23.0 [ 12315571 ]
          Affects Version/s 0.23.0 [ 12315571 ]
          Hide
          Bharath Mundlapudi added a comment -

          Attaching a patch for this.

          Show
          Bharath Mundlapudi added a comment - Attaching a patch for this.
          Bharath Mundlapudi made changes -
          Attachment HDFS-1776-1.patch [ 12487082 ]
          Hide
          Dmytro Molkov added a comment -

          Thank you Bharath! Code looks good

          Show
          Dmytro Molkov added a comment - Thank you Bharath! Code looks good
          Hide
          Dmytro Molkov added a comment -

          Submitting the patch to hudson

          Show
          Dmytro Molkov added a comment - Submitting the patch to hudson
          Dmytro Molkov made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12487082/HDFS-1776-1.patch
          against trunk revision 1148981.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/990//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/990//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/990//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12487082/HDFS-1776-1.patch against trunk revision 1148981. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/990//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/990//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/990//console This message is automatically generated.
          Hide
          Dmytro Molkov added a comment -

          I just committed this. Thanks Bharath

          Show
          Dmytro Molkov added a comment - I just committed this. Thanks Bharath
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #803 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/803/)
          HDFS-1776 Bug in Bug in Concat code. Contributed by Bharath Mundlapudi

          molkov : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1150247
          Files :

          • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/INodeFile.java
          • /hadoop/common/trunk/hdfs/CHANGES.txt
          • /hadoop/common/trunk/hdfs/src/test/unit/org/apache/hadoop/hdfs/server/namenode/TestINodeFile.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #803 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/803/ ) HDFS-1776 Bug in Bug in Concat code. Contributed by Bharath Mundlapudi molkov : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1150247 Files : /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/INodeFile.java /hadoop/common/trunk/hdfs/CHANGES.txt /hadoop/common/trunk/hdfs/src/test/unit/org/apache/hadoop/hdfs/server/namenode/TestINodeFile.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #734 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/734/)
          HDFS-1776 Bug in Bug in Concat code. Contributed by Bharath Mundlapudi

          molkov : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1150247
          Files :

          • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/INodeFile.java
          • /hadoop/common/trunk/hdfs/CHANGES.txt
          • /hadoop/common/trunk/hdfs/src/test/unit/org/apache/hadoop/hdfs/server/namenode/TestINodeFile.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #734 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/734/ ) HDFS-1776 Bug in Bug in Concat code. Contributed by Bharath Mundlapudi molkov : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1150247 Files : /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/INodeFile.java /hadoop/common/trunk/hdfs/CHANGES.txt /hadoop/common/trunk/hdfs/src/test/unit/org/apache/hadoop/hdfs/server/namenode/TestINodeFile.java
          Luke Lu made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Hadoop Flags [Reviewed]
          Resolution Fixed [ 1 ]
          Arun C Murthy made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Patch Available Patch Available
          120d 12h 42m 1 Dmytro Molkov 21/Jul/11 18:30
          Patch Available Patch Available Resolved Resolved
          22d 4h 22m 1 Luke Lu 12/Aug/11 22:53
          Resolved Resolved Closed Closed
          94d 2h 59m 1 Arun C Murthy 15/Nov/11 00:52

            People

            • Assignee:
              Bharath Mundlapudi
              Reporter:
              Dmytro Molkov
            • Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development