Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-1763

Replace hard-coded option strings with variables from DFSConfigKeys

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 0.23.0
    • None
    • None
    • Reviewed

    Description

      There are some places in the code where we use hard-coded strings instead of the equivalent DFSConfigKeys define, and a couple places where the default is defined multiple places (once in DFSConfigKeys and once elsewhere, though both have the same value). This is error-prone, and also a pain in that it prevents eclipse from easily showing you all the places where a particular config option is used. Let's replace all the uses of the hard-coded option strings with uses of the corresponding variables in DFSConfigKeys.

      Attachments

        1. hdfs-1763-2.patch
          92 kB
          Eli Collins
        2. hdfs-1763-1.patch
          96 kB
          Eli Collins

        Issue Links

          is related to

          Test - A new unit, integration or system test. HDFS-1770 TestFiRename fails due to invalid block size

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Activity

            People

              eli Eli Collins
              eli Eli Collins
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: