[HDFS-17636] Don't add declspec for Windows

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 3.5.0
• Fix Version/s: 3.5.0
• Component/s: libhdfs
• Labels: pull-request-available

Environment

Windows 10/11

• Target Version/s: 3.5.0

Language

C C++

• Assignee: Gautham Banasandra
• Reporter: Gautham Banasandra
• Due: 10/Oct/24
• Created: 02/Oct/24 20:16
• Updated: 22/Oct/24 17:47
• Resolved: 22/Oct/24 17:47

Description

• Windows doesn't want the
  macro JNI_IMPORT_OR_EXPORT
  to be defined in the function
  definition. It fails to compile with
  the following error -
  "definition of dllimport function
  not allowed".
• However, Linux needs it. Hence,
  we're going to add this macro
  based on the OS.

Issue Links

• is caused by: HDFS-16084 getJNIEnv() returns invalid pointer when called twice after getGlobalJNIEnv() failed
• links to: GitHub Pull Request #7096