Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-1734

'Chunk size to view' option is not working in Name Node UI.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.23.0
    • Component/s: namenode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      1. Write a file to DFS
      2. Browse the file using Name Node UI.
      3. give the chunk size to view as 100 and click the refresh.

      It will say Invalid input ( getnstamp absent )

      1. HDFS-1734.2.patch
        5 kB
        Uma Maheswara Rao G
      2. HDFS-1734.1.patch
        5 kB
        Uma Maheswara Rao G
      3. HDFS-1734.patch
        5 kB
        Uma Maheswara Rao G
      4. ASF.LICENSE.NOT.GRANTED--ChunkSizeToView.jpg
        135 kB
        Uma Maheswara Rao G

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #702 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/702/)

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #702 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/702/ )
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #750 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/750/)
        HDFS-1734. 'Chunk size to view' option is not working in Name Node UI. Contributed by Uma Maheswara Rao G.

        jitendra : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1136975
        Files :

        • /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/datanode/DatanodeJspHelper.java
        • /hadoop/common/trunk/hdfs/CHANGES.txt
        • /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/server/datanode/TestDatanodeJsp.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #750 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/750/ ) HDFS-1734 . 'Chunk size to view' option is not working in Name Node UI. Contributed by Uma Maheswara Rao G. jitendra : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1136975 Files : /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/datanode/DatanodeJspHelper.java /hadoop/common/trunk/hdfs/CHANGES.txt /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/server/datanode/TestDatanodeJsp.java
        Hide
        Jitendra Nath Pandey added a comment -

        I have committed this. Thanks to Uma Maheswara!

        Show
        Jitendra Nath Pandey added a comment - I have committed this. Thanks to Uma Maheswara!
        Hide
        Uma Maheswara Rao G added a comment -

        Test failures are not related to this change.

        Show
        Uma Maheswara Rao G added a comment - Test failures are not related to this change.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12482339/HDFS-1734.2.patch
        against trunk revision 1135329.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 5 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these core unit tests:
        org.apache.hadoop.cli.TestHDFSCLI
        org.apache.hadoop.hdfs.server.datanode.TestBlockRecovery

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/783//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/783//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/783//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12482339/HDFS-1734.2.patch against trunk revision 1135329. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 5 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.cli.TestHDFSCLI org.apache.hadoop.hdfs.server.datanode.TestBlockRecovery +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/783//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/783//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/783//console This message is automatically generated.
        Hide
        Jitendra Nath Pandey added a comment -

        +1 for the patch. I will commit once test/test-patch results are available.

        Show
        Jitendra Nath Pandey added a comment - +1 for the patch. I will commit once test/test-patch results are available.
        Hide
        Uma Maheswara Rao G added a comment -

        Above tests failures are not related to this change.

        Show
        Uma Maheswara Rao G added a comment - Above tests failures are not related to this change.
        Hide
        Uma Maheswara Rao G added a comment -

        Thanks Jitendra for Review.
        Updated the patch against to latest trunk.

        Show
        Uma Maheswara Rao G added a comment - Thanks Jitendra for Review. Updated the patch against to latest trunk.
        Hide
        Jitendra Nath Pandey added a comment -

        Hi Uma,
        Sorry for a delay in response. The patch looks good to me now, however you might have to update the patch against the latest trunk. Also, please comment on the test failures.

        Show
        Jitendra Nath Pandey added a comment - Hi Uma, Sorry for a delay in response. The patch looks good to me now, however you might have to update the patch against the latest trunk. Also, please comment on the test failures.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12474792/HDFS-1734.1.patch
        against trunk revision 1085509.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 4 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these core unit tests:
        org.apache.hadoop.cli.TestHDFSCLI
        org.apache.hadoop.hdfs.server.datanode.TestBlockReport
        org.apache.hadoop.hdfs.TestDFSShell
        org.apache.hadoop.hdfs.TestFileAppend4
        org.apache.hadoop.hdfs.TestFileConcurrentReader
        org.apache.hadoop.hdfs.TestLargeBlock
        org.apache.hadoop.hdfs.TestWriteConfigurationToDFS

        -1 contrib tests. The patch failed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/294//testReport/
        Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/294//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/294//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12474792/HDFS-1734.1.patch against trunk revision 1085509. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 4 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.cli.TestHDFSCLI org.apache.hadoop.hdfs.server.datanode.TestBlockReport org.apache.hadoop.hdfs.TestDFSShell org.apache.hadoop.hdfs.TestFileAppend4 org.apache.hadoop.hdfs.TestFileConcurrentReader org.apache.hadoop.hdfs.TestLargeBlock org.apache.hadoop.hdfs.TestWriteConfigurationToDFS -1 contrib tests. The patch failed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/294//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/294//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/294//console This message is automatically generated.
        Hide
        Uma Maheswara Rao G added a comment -

        Hi Jitendra,
        Fixed the comments and provided the patch. Please check it.

        Show
        Uma Maheswara Rao G added a comment - Hi Jitendra, Fixed the comments and provided the patch. Please check it.
        Hide
        Jitendra Nath Pandey added a comment -

        Correct, I missed that genstamp was being added as hidden input.

        A few more comments:
        1. Please use junit4 for test. You don't have to extend from TestCase.
        2. testGenerateFileDetailsShouldPrintTheGetstampInJSPWriter is too long a name. A shorter name like testGenStamp might suffice.
        3. The patch has ^M at the end of every line, probably because the file was generated on a windows box. Can you clean that up?
        4. > FileSystem fs = FileSystem.get(CONF);
        I will recommend using fs = cluster.getFileSystem().

        Show
        Jitendra Nath Pandey added a comment - Correct, I missed that genstamp was being added as hidden input. A few more comments: 1. Please use junit4 for test. You don't have to extend from TestCase. 2. testGenerateFileDetailsShouldPrintTheGetstampInJSPWriter is too long a name. A shorter name like testGenStamp might suffice. 3. The patch has ^M at the end of every line, probably because the file was generated on a windows box. Can you clean that up? 4. > FileSystem fs = FileSystem.get(CONF); I will recommend using fs = cluster.getFileSystem().
        Hide
        Uma Maheswara Rao G added a comment -

        Thanks Jithendra for Review,
        Here this fix will solve this problem, because When we click on the file name in NN UI, generateFileDetails will write all the parameters in to page as hidden.

        out.print("<input type=\"hidden\" name=\"genstamp\" value=\"" + genStamp
        + + "\">")

        When we click refresh, the same parameters will be resubmitted.

        The initial problem is, when we click on file to open from UI, we missed to write genstamp as hidden parameter. So, when the refresh happens that parameter is missing.

        With this patch refresh button is working.

        Show
        Uma Maheswara Rao G added a comment - Thanks Jithendra for Review, Here this fix will solve this problem, because When we click on the file name in NN UI, generateFileDetails will write all the parameters in to page as hidden. out.print("<input type=\" hidden \" name=\"genstamp\" value=\"" + genStamp + + "\">") When we click refresh, the same parameters will be resubmitted. The initial problem is, when we click on file to open from UI, we missed to write genstamp as hidden parameter. So, when the refresh happens that parameter is missing. With this patch refresh button is working.
        Hide
        Jitendra Nath Pandey added a comment -

        This patch doesn't seem to fix the problem of "absent genstamp". Since, generateFileChunks looks for genstamp in the request, genstamp must be added to the request parameters. Isn't it or am I missing something?

        Show
        Jitendra Nath Pandey added a comment - This patch doesn't seem to fix the problem of "absent genstamp". Since, generateFileChunks looks for genstamp in the request, genstamp must be added to the request parameters. Isn't it or am I missing something?
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12473272/HDFS-1734.patch
        against trunk revision 1080095.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 4 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these core unit tests:
        org.apache.hadoop.hdfs.server.balancer.TestBalancer
        org.apache.hadoop.hdfs.server.datanode.TestBlockReport
        org.apache.hadoop.hdfs.TestFileAppend4
        org.apache.hadoop.hdfs.TestFileConcurrentReader
        org.apache.hadoop.hdfs.TestLargeBlock
        org.apache.hadoop.hdfs.TestWriteConfigurationToDFS

        -1 contrib tests. The patch failed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/245//testReport/
        Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/245//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/245//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12473272/HDFS-1734.patch against trunk revision 1080095. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 4 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.hdfs.server.balancer.TestBalancer org.apache.hadoop.hdfs.server.datanode.TestBlockReport org.apache.hadoop.hdfs.TestFileAppend4 org.apache.hadoop.hdfs.TestFileConcurrentReader org.apache.hadoop.hdfs.TestLargeBlock org.apache.hadoop.hdfs.TestWriteConfigurationToDFS -1 contrib tests. The patch failed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/245//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/245//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/245//console This message is automatically generated.
        Hide
        Uma Maheswara Rao G added a comment -

        Patch provided

        Show
        Uma Maheswara Rao G added a comment - Patch provided
        Hide
        Uma Maheswara Rao G added a comment -

        In DatanodeJspHelper.generateFileDetails() method , we should get the genstamp parameter from HttpServletRequest and print it on to JspWriter.

        Show
        Uma Maheswara Rao G added a comment - In DatanodeJspHelper.generateFileDetails() method , we should get the genstamp parameter from HttpServletRequest and print it on to JspWriter.

          People

          • Assignee:
            Uma Maheswara Rao G
            Reporter:
            Uma Maheswara Rao G
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development