Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-1731

Allow using a file to exclude certain tests from build

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.23.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      It would be nice to be able to exclude certain tests when running builds. For example, when a test is "known flaky", you may want to exclude it from the main Hudson job, but not actually disable it in the codebase (so that it still runs as part of another Hudson job, for example).

      1. hdfs-1731-cygwin-fix.txt
        1 kB
        Todd Lipcon
      2. hdfs-1731.txt
        1 kB
        Todd Lipcon

        Issue Links

          Activity

          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #643 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/643/)

          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #643 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/643/ )
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #582 (See https://hudson.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/582/)

          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #582 (See https://hudson.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/582/ )
          Hide
          Tsz Wo Nicholas Sze added a comment -

          That's great! Thanks.

          Show
          Tsz Wo Nicholas Sze added a comment - That's great! Thanks.
          Hide
          Todd Lipcon added a comment -

          OK, thanks for clarifying. I've fixed this in svn.

          Show
          Todd Lipcon added a comment - OK, thanks for clarifying. I've fixed this in svn.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          The later is better. We usually put a short description in CHANGES.txt for what we do in the issue. This is what most people care. For multiple commits, we could track them in svn logs.

          Show
          Tsz Wo Nicholas Sze added a comment - The later is better. We usually put a short description in CHANGES.txt for what we do in the issue. This is what most people care. For multiple commits, we could track them in svn logs.
          Hide
          Todd Lipcon added a comment -

          Hi Nicholas. Would you prefer that the "amend" commit be entirely removed, or that both messages be collapsed under one heading?

          ie:

              HDFS-1731. Allow using a file to exclude certain tests from build (todd)
                         Amend previous commit for this JIRA to fix build on Cygwin. (todd)
          

          or just:

              HDFS-1731. Allow using a file to exclude certain tests from build (todd)
          
          Show
          Todd Lipcon added a comment - Hi Nicholas. Would you prefer that the "amend" commit be entirely removed, or that both messages be collapsed under one heading? ie: HDFS-1731. Allow using a file to exclude certain tests from build (todd) Amend previous commit for this JIRA to fix build on Cygwin. (todd) or just: HDFS-1731. Allow using a file to exclude certain tests from build (todd)
          Hide
          Tsz Wo Nicholas Sze added a comment -

          Hi Todd,

          In Hadoop, we only put one entry per JIRA in CHANGES.txt. Could you combine the HDFS-1731 entries?

              HDFS-1731. Allow using a file to exclude certain tests from build (todd)
          
              HDFS-1736. Remove the dependency from DatanodeJspHelper to FsShell.
              (Daryn Sharp via szetszwo)
              
              HDFS-1731. Amend previous commit for this JIRA to fix build on Cygwin.
              (todd)
          
          Show
          Tsz Wo Nicholas Sze added a comment - Hi Todd, In Hadoop, we only put one entry per JIRA in CHANGES.txt. Could you combine the HDFS-1731 entries? HDFS-1731. Allow using a file to exclude certain tests from build (todd) HDFS-1736. Remove the dependency from DatanodeJspHelper to FsShell. (Daryn Sharp via szetszwo) HDFS-1731. Amend previous commit for this JIRA to fix build on Cygwin. (todd)
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #557 (See https://hudson.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/557/)
          HDFS-1731. Amend previous commit for this JIRA to fix build on Cygwin. Contributed by Todd Lipcon

          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #557 (See https://hudson.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/557/ ) HDFS-1731 . Amend previous commit for this JIRA to fix build on Cygwin. Contributed by Todd Lipcon
          Hide
          Todd Lipcon added a comment -

          Committed fix to trunk. Sorry about this one Nicholas.

          Show
          Todd Lipcon added a comment - Committed fix to trunk. Sorry about this one Nicholas.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          +1

          Show
          Tsz Wo Nicholas Sze added a comment - +1
          Hide
          Todd Lipcon added a comment -

          Fix for cygwin

          Show
          Todd Lipcon added a comment - Fix for cygwin
          Hide
          Todd Lipcon added a comment -

          Reopening to address issue on cygwin reported by Nicholas

          Show
          Todd Lipcon added a comment - Reopening to address issue on cygwin reported by Nicholas
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #555 (See https://hudson.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/555/)

          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #555 (See https://hudson.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/555/ )
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12472873/hdfs-1731.txt
          against trunk revision 1078940.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these core unit tests:
          org.apache.hadoop.hdfs.server.balancer.TestBalancer
          org.apache.hadoop.hdfs.server.namenode.TestBackupNode
          org.apache.hadoop.hdfs.TestFileConcurrentReader

          -1 contrib tests. The patch failed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/237//testReport/
          Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/237//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/237//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12472873/hdfs-1731.txt against trunk revision 1078940. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.hdfs.server.balancer.TestBalancer org.apache.hadoop.hdfs.server.namenode.TestBackupNode org.apache.hadoop.hdfs.TestFileConcurrentReader -1 contrib tests. The patch failed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/237//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/237//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/237//console This message is automatically generated.
          Hide
          Konstantin Boudnik added a comment -

          +1 patch looks good. With only exception that we shouldn't overuse this 'facility'

          Show
          Konstantin Boudnik added a comment - +1 patch looks good. With only exception that we shouldn't overuse this 'facility'

            People

            • Assignee:
              Todd Lipcon
              Reporter:
              Todd Lipcon
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development