[HDFS-17133] TestFsDatasetImpl missing null check when cleaning up

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 3.4.0
• Fix Version/s: 3.4.0
• Component/s: test
• Labels: pull-request-available
• Target Version/s: 3.4.0
• Hadoop Flags: Reviewed
• Assignee: ConfX
• Reporter: ConfX
• Created: 27/Jul/23 15:04
• Updated: 28/Jan/24 01:50
• Resolved: 29/Sep/23 06:37

Description

What happened

I turned on dfs.namenode.quota.init-threads=1468568631 and then the test org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl#testMoveBlockFailurefails with null pointer.

Where's the problem

In the clean up part of the test:

    } finally {
      if (cluster.isClusterUp()) {
        cluster.shutdown();
      }
    }

if cluster is null, the test would directly fail with a null pointer exception and hiding potentially the actual failure.

How to reproduce

1. set dfs.namenode.quota.init-threads=1468568631 {}
2. run org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl#testMoveBlockFailure
   you should observe

   java.lang.NullPointerException
       at org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl.testMoveBlockFailure(TestFsDatasetImpl.java:1005)

   For an easy reproduction, run the reproduce.sh in the attachment.

We are happy to provide a patch if this issue is confirmed.

Issue Links

• links to: GitHub Pull Request #6079