[HDFS-16909] Improve ReplicaMap#mergeAll method.

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.4.0
• Fix Version/s: 3.4.0
• Component/s: datanode
• Labels: pull-request-available
• Target Version/s: 3.4.0
• Hadoop Flags: Reviewed
• Assignee: farmmamba
• Reporter: farmmamba
• Created: 06/Feb/23 03:31
• Updated: 28/Jan/24 07:20
• Resolved: 21/May/23 11:12

Description

Currently, the code is as below:

for (ReplicaInfo replicaInfo : replicaSet) {
  checkBlock(replicaInfo);
  if (curSet == null) {
    // Add an entry for block pool if it does not exist already
    curSet = new LightWeightResizableGSet<>();
    map.put(bp, curSet);
  }
  curSet.put(replicaInfo);
} 

the statment :

if(curSet == null)

should be moved to outside from the for loop.

Issue Links

• links to: GitHub Pull Request #5353