[HDFS-16891] Avoid the overhead of copy-on-write exception list while loading inodes sub sections in parallel

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.3.4
• Fix Version/s: 3.4.0, 3.3.6
• Component/s: namenode
• Labels: pull-request-available
• Target Version/s: 3.4.0, 3.3.9
• Hadoop Flags: Reviewed
• Assignee: Viraj Jasani
• Reporter: Viraj Jasani
• Created: 14/Jan/23 00:17
• Updated: 28/Jan/24 07:26
• Resolved: 18/Jan/23 21:57

Description

If we enable parallel loading and persisting of inodes from/to fs image, we get the benefit of improved performance. However, while loading sub-sections INODE_DIR_SUB and INODE_SUB, if we encounter any errors, we use copy-on-write list to maintain the list of exceptions. Since our usecase is not to iterate over this list while executor threads are adding new elements to the list, using copy-on-write is bit of an overhead for this usecase.

It would be better to synchronize adding new elements to the list rather than having the list copy all elements over every time new element is added to the list.

Issue Links

• links to: GitHub Pull Request #5300