[HDFS-16847] RBF: StateStore writer should not commit tmp fail if there was an error in writing the file.

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 3.4.0, 3.3.5
• Fix Version/s: 3.4.0, 3.3.5
• Component/s: hdfs, rbf
• Labels: pull-request-available
• Target Version/s: 3.4.0, 3.3.5
• Hadoop Flags: Reviewed
• Assignee: Simbarashe Dzinamarira
• Reporter: Simbarashe Dzinamarira
• Created: 18/Nov/22 01:11
• Updated: 28/Jan/24 07:37
• Resolved: 29/Nov/22 00:51

Description

The file based implementation of the RBF state store has a commit step that moves a temporary file to a permanent location.

There is a check to see if the write of the temp file was successfully, however, the code to commit doesn't check the success flag.

This is the relevant code: https://github.com/apache/hadoop/blob/7d39abd799a5f801a9fd07868a193205ab500bfa/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/store/driver/impl/StateStoreFileBaseImpl.java#L369

 

Issue Links

• links to: GitHub Pull Request #5145