[HDFS-16838] Fix NPE in testAddRplicaProcessorForAddingReplicaInMap

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.4.0
• Fix Version/s: 3.4.0
• Component/s: test
• Labels: pull-request-available
• Target Version/s: 3.4.0
• Hadoop Flags: Reviewed
• Assignee: ZanderXu
• Reporter: ZanderXu
• Created: 11/Nov/22 03:01
• Updated: 28/Jan/24 07:52
• Resolved: 24/Nov/22 01:21

Description

There is a NPE in org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.TestFsVolumeList#testAddRplicaProcessorForAddingReplicaInMap if we run this UT individually. And the related bug as bellow:

 

public void testAddRplicaProcessorForAddingReplicaInMap() throws Exception {
  // BUG here
  BlockPoolSlice.reInitializeAddReplicaThreadPool();
  Configuration cnf = new Configuration();
  int poolSize = 5; 
  ...
}

 

addReplicaThreadPool may not have been initialized and is null, if we run testAddRplicaProcessorForAddingReplicaInMap unit test as an individual unit test.

@VisibleForTesting
public static void reInitializeAddReplicaThreadPool() {
  addReplicaThreadPool.shutdown();
  addReplicaThreadPool = null;
}

Issue Links

• links to: GitHub Pull Request #5125