[HDFS-16826] [RBF SBN] ConnectionManager should advance the client stateId for every request

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.4.0
• Fix Version/s: 3.4.0
• Component/s: namenode, rbf
• Labels: pull-request-available
• Target Version/s: 3.4.0
• Hadoop Flags: Reviewed
• Assignee: ZanderXu
• Reporter: ZanderXu
• Created: 28/Oct/22 09:31
• Updated: 16/Oct/24 18:29
• Resolved: 25/Nov/22 01:24

Description

ConnectionManager should advance the client stateId for every request whatever pool is null or not.

 

Bug Code as bellow:

// Create the pool if not created before
if (pool == null) {
  writeLock.lock();
  try {
    pool = this.pools.get(connectionId);
    if (pool == null) {
      pool = new ConnectionPool(
          this.conf, nnAddress, ugi, this.minSize, this.maxSize,
          this.minActiveRatio, protocol,
          new PoolAlignmentContext(this.routerStateIdContext, nsId));
      this.pools.put(connectionId, pool);
      this.connectionPoolToNamespaceMap.put(connectionId, nsId);
    }
    // BUG Here
    long clientStateId = RouterStateIdContext.getClientStateIdFromCurrentCall(nsId);
    pool.getPoolAlignmentContext().advanceClientStateId(clientStateId);
  } finally {
    writeLock.unlock();
  }
} 

 

Issue Links

• is caused by: HDFS-13522 HDFS-13522: Add federated nameservices states to client protocol and propagate it between routers and clients.
• relates to: HDFS-13522 HDFS-13522: Add federated nameservices states to client protocol and propagate it between routers and clients.
• links to: GitHub Pull Request #5086