[HDFS-16813] Remove parameter validation logic such as dfs.namenode.decommission.blocks.per.interval in DatanodeAdminManager#activate

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.4.0
• Fix Version/s: 3.4.0
• Component/s: datanode
• Labels: pull-request-available
• Target Version/s: 3.4.0
• Hadoop Flags: Reviewed
• Assignee: Haiyang Hu
• Reporter: Haiyang Hu
• Created: 22/Oct/22 08:41
• Updated: 28/Jan/24 07:58
• Resolved: 23/Nov/22 01:53

Description

In DatanodeAdminManager#activate

int blocksPerInterval = conf.getInt(
    DFSConfigKeys.DFS_NAMENODE_DECOMMISSION_BLOCKS_PER_INTERVAL_KEY,
    DFSConfigKeys.DFS_NAMENODE_DECOMMISSION_BLOCKS_PER_INTERVAL_DEFAULT);

final String deprecatedKey =
    "dfs.namenode.decommission.nodes.per.interval";
final String strNodes = conf.get(deprecatedKey);
if (strNodes != null) {
  LOG.warn("Deprecated configuration key {} will be ignored.",
      deprecatedKey);
  LOG.warn("Please update your configuration to use {} instead.",
      DFSConfigKeys.DFS_NAMENODE_DECOMMISSION_BLOCKS_PER_INTERVAL_KEY);
}

checkArgument(blocksPerInterval > 0,
    "Must set a positive value for "
    + DFSConfigKeys.DFS_NAMENODE_DECOMMISSION_BLOCKS_PER_INTERVAL_KEY);

final int maxConcurrentTrackedNodes = conf.getInt(
    DFSConfigKeys.DFS_NAMENODE_DECOMMISSION_MAX_CONCURRENT_TRACKED_NODES,
    DFSConfigKeys
        .DFS_NAMENODE_DECOMMISSION_MAX_CONCURRENT_TRACKED_NODES_DEFAULT);
checkArgument(maxConcurrentTrackedNodes >= 0, "Cannot set a negative " +
    "value for "
    + DFSConfigKeys.DFS_NAMENODE_DECOMMISSION_MAX_CONCURRENT_TRACKED_NODES);

there is no need for parameters
dfs.namenode.decommission.blocks.per.interval and
dfs.namenode.decommission.max.concurrent.tracked.nodes to verify.
Because the parameters are processed in DatanodeAdminMonitorBase and DatanodeAdminDefaultMonitor.

Issue Links

• links to: GitHub Pull Request #5063