[HDFS-16709] Remove redundant cast in FSEditLogOp.class

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.4.0
• Fix Version/s: 3.4.0
• Component/s: namenode
• Labels: pull-request-available
• Target Version/s: 3.4.0
• Hadoop Flags: Reviewed
• Assignee: ZanderXu
• Reporter: ZanderXu
• Created: 01/Aug/22 13:13
• Updated: 16/Oct/24 18:29
• Resolved: 08/Aug/22 19:24

Description

When I read some class about Edits of NameNode, I found that there are much redundant cast in FSEditLogOp.class, I feel that we should remove them.

Such as:

static UpdateBlocksOp getInstance(OpInstanceCache cache) {
  return (UpdateBlocksOp)cache.get(OP_UPDATE_BLOCKS);
} 

Because cache.get() have cast the response to T, such as:

@SuppressWarnings("unchecked")
public <T extends FSEditLogOp> T get(FSEditLogOpCodes opCode) {
  return useCache ? (T)CACHE.get().get(opCode) : (T)newInstance(opCode);
} 

Issue Links

• links to: GitHub Pull Request #4667