[HDFS-16680] Skip libhdfspp Valgrind tests on Windows

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.4.0
• Fix Version/s: 3.4.0
• Component/s: libhdfs++
• Labels: pull-request-available

Environment

Windows 10

Language

CMake

• Assignee: Gautham Banasandra
• Reporter: Gautham Banasandra
• Due: 29/Jul/22
• Created: 22/Jul/22 17:00
• Updated: 23/Jul/22 17:53
• Resolved: 23/Jul/22 17:53

Description

The CMake test libhdfs_mini_stress_valgrind requires Valgrind - https://github.com/apache/hadoop/blob/221eb2d68d5b52e4394fd36cb30d5ee9ffeea7f0/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/tests/CMakeLists.txt#L172-L175

build_libhdfs_test(libhdfs_mini_stress_valgrind hdfspp_test_static expect.c test_libhdfs_mini_stress.c ${OS_DIR}/thread.c)
link_libhdfs_test(libhdfs_mini_stress_valgrind hdfspp_test_static fs reader rpc proto common connection ${PROTOBUF_LIBRARIES} ${OPENSSL_LIBRARIES} native_mini_dfs ${JAVA_JVM_LIBRARY} ${SASL_LIBRARIES})
add_memcheck_test(libhdfs_mini_stress_valgrind_hdfspp_test_static libhdfs_mini_stress_valgrind_hdfspp_test_static)
set_target_properties(libhdfs_mini_stress_valgrind_hdfspp_test_static PROPERTIES COMPILE_DEFINITIONS "VALGRIND")

We need to skip this test on Windows since we don't have Valgrind on Windows.

Issue Links

• is a child of: HADOOP-17193 Compile Hadoop on Windows natively
• links to: GitHub Pull Request #4611