[HDFS-16667] Use malloc for buffer allocation in uriparser2

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.4.0
• Fix Version/s: 3.4.0
• Component/s: libhdfs++
• Labels: libhdfscpp pull-request-available

Environment

Windows 10

Language

C++

• Assignee: Gautham Banasandra
• Reporter: Gautham Banasandra
• Due: 25/Jul/22
• Created: 18/Jul/22 05:16
• Updated: 20/Jul/22 16:28
• Resolved: 20/Jul/22 16:28

Description

Currently, a variable is used to specify the array size in uriparser2 -
https://github.com/apache/hadoop/blob/34e548cb62ed21c5bba7a82f5f1489ca6bdfb8c4/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/third_party/uriparser2/uriparser2/uriparser2.c#L71-L79

static int parse_int(const char *first, const char *after_last) {
	const int size = after_last - first;
	if (size) {
		char buffer[size + 1];
		memcpyz(buffer, first, size);
		return atoi(buffer);
	}
	return 0;
}

This results in the following error on Windows -

H:\hadoop-hdfs-project\hadoop-hdfs-native-client\src\out\build\x64-Debug\cl : command line warning D9025: overriding '/W4' with '/w' 
    uriparser2.c
H:\hadoop-hdfs-project\hadoop-hdfs-native-client\src\main\native\libhdfspp\third_party\uriparser2\uriparser2\uriparser2.c(74,23): error C2057: expected constant expression 
H:\hadoop-hdfs-project\hadoop-hdfs-native-client\src\main\native\libhdfspp\third_party\uriparser2\uriparser2\uriparser2.c(74,23): error C2466: cannot allocate an array of constant size 0 
H:\hadoop-hdfs-project\hadoop-hdfs-native-client\src\main\native\libhdfspp\third_party\uriparser2\uriparser2\uriparser2.c(74,24): error C2133: 'buffer': unknown size 

Thus, we need to use malloc to fix this.

Issue Links

• is a child of: HADOOP-17193 Compile Hadoop on Windows natively
• links to: GitHub Pull Request #4576