Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-16658

BlockManager should output some logs when logEveryBlock is true.

VotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Reviewed

    Description

      During locating some abnormal cases in our prod environment, I found that BlockManager does not out put some logs in `addStoredBlock` even though `logEveryBlock` is true.

      I feel that we need to change the log level from DEBUG to INFO.

      // Some comments here
      private Block addStoredBlock(final BlockInfo block,
                                     final Block reportedBlock,
                                     DatanodeStorageInfo storageInfo,
                                     DatanodeDescriptor delNodeHint,
                                     boolean logEveryBlock)
        throws IOException {
          ....
            if (logEveryBlock) {
              blockLog.debug("BLOCK* addStoredBlock: {} is added to {} (size={})",
                  node, storedBlock, storedBlock.getNumBytes());
            }
          ...
        }
      

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            xuzq_zander ZanderXu
            xuzq_zander ZanderXu
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 1.5h
                1.5h

                Slack

                  Issue deployment