[HDFS-16561] Handle error returned by strtol

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.4.0
• Fix Version/s: 3.4.0
• Component/s: libhdfs++
• Labels: pull-request-available
• Target Version/s: 3.4.0
• Hadoop Flags: Reviewed
• Assignee: Gautham Banasandra
• Reporter: Gautham Banasandra
• Created: 25/Apr/22 10:21
• Updated: 27/Jan/24 01:27
• Resolved: 26/May/22 05:43

Description

strtol is used in hdfs-chmod.cc. The call to strtol could error out when an invalid input is provided. Need to handle the error given out by strtol.

Tasks to do -
1. Detect the error returned by strtol. The strtol documentation explains how to do so.
2. Return false to the caller if the error is detected.
3. Extend this unit test and add a case which exercises this by passing an invalid input. Please refer to this PR to get more context on how this unit test is written - https://github.com/apache/hadoop/pull/3588.

Issue Links

• relates to: HDFS-16285 Make HDFS ownership tools cross platform
• links to: GitHub Pull Request #4287