[HDFS-16543] Keep default value of dfs.datanode.directoryscan.throttle.limit.ms.per.sec consistent

• Type: Improvement
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 3.3.2
• Component/s: configuration, datanode
• Labels: pull-request-available
• Assignee: daimin
• Reporter: daimin
• Created: 15/Apr/22 08:48
• Updated: 19/May/22 03:35

Description

"WARN datanode.DirectoryScanner (DirectoryScanner.java:<init>(300)) - dfs.datanode.directoryscan.throttle.limit.ms.per.sec set to value above 1000 ms/sec. Assuming default value of -1"
A warning log like above will be printed when datanode is starting. The reason of that is the default value of dfs.datanode.directoryscan.throttle.limit.ms.per.sec is 1000 in hdfs-site.xml, and is -1 in DFS_DATANODE_DIRECTORYSCAN_THROTTLE_LIMIT_MS_PER_SEC_DEFAULT. We should try to keep it consistent, and value -1 looks is better to 1000.

The code segment that print the warning log:

if (throttle >= TimeUnit.SECONDS.toMillis(1)) {
LOG.warn(
"{} set to value above 1000 ms/sec. Assuming default value of {}",
DFSConfigKeys.DFS_DATANODE_DIRECTORYSCAN_THROTTLE_LIMIT_MS_PER_SEC_KEY,
DFSConfigKeys.DFS_DATANODE_DIRECTORYSCAN_THROTTLE_LIMIT_MS_PER_SEC_DEFAULT);
throttle =
DFSConfigKeys.DFS_DATANODE_DIRECTORYSCAN_THROTTLE_LIMIT_MS_PER_SEC_DEFAULT;
}

Issue Links

• links to: GitHub Pull Request #4178