[HDFS-16525] System.err should be used when error occurs in multiple methods in DFSAdmin class

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.3.2
• Fix Version/s: 3.4.0
• Component/s: dfsadmin
• Labels: pull-request-available
• Assignee: yanbin.zhang
• Reporter: yanbin.zhang
• Created: 30/Mar/22 13:48
• Updated: 12/May/22 09:16
• Resolved: 12/May/22 08:55

Description

System.err should be used when error occurs in multiple methods in DFSAdmin class,as follows:

//DFSAdmin#refreshCallQueue
...
try{
  proxy.getProxy().refreshCallQueue();
  System.out.println("Refresh call queue successful for "
      + proxy.getAddress());
}catch (IOException ioe){
  System.out.println("Refresh call queue failed for "
      + proxy.getAddress());
  exceptions.add(ioe);
}
...

The test method closed first in TestDFSAdminWithHA also needs to be modified,otherwise an error will be reported,similar to the following:

[ERROR] Failures:
[ERROR]   TestDFSAdminWithHA.testRefreshCallQueueNN1DownNN2Up:726->assertOutputMatches:77 Expected output to match 'Refresh call queue failed for.*
Refresh call queue successful for.*
' but err_output was:
Refresh call queue failed for localhost/127.0.0.1:12876
refreshCallQueue: Call From h110/10.1.234.110 to localhost:12876 failed on connection exception: java.net.ConnectException: Connection refused; For more details see:  http://wiki.apache.org/hadoop/ConnectionRefused and output was:
Refresh call queue successful for localhost/127.0.0.1:12878

Issue Links

• links to: GitHub Pull Request #4122