[HDFS-16467] Ensure Protobuf generated headers are included first

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.4.0
• Fix Version/s: 3.4.0
• Component/s: libhdfs++
• Labels: libhdfscpp pull-request-available

Environment

Windows 10

Language

C C++

• Assignee: Gautham Banasandra
• Reporter: Gautham Banasandra
• Created: 20/Feb/22 08:31
• Updated: 23/Jul/22 17:51
• Resolved: 23/Jul/22 17:51

Description

We need to ensure that the Protobuf generated headers (such as ClientNamenodeProtocol.pb.h) are included at the top. In other words, *.ph.h should be the first header files to be included in any of the .c/.cc/.h files. Otherwise, it causes symbol redefinition errors during compilation. Also, we need to ensure that Protobuf generated header files are the first ones to be included even in the case of transitive inclusion of header files.

This issue seems to be specific to Windows only. Not sure why the other platforms aren't running into this.

Issue Links

• is a child of: HADOOP-17193 Compile Hadoop on Windows natively
• links to: GitHub Pull Request #4601