[HDFS-16406] DataNode metric ReadsFromLocalClient does not count short-circuit reads

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.4.0
• Fix Version/s: 3.4.0
• Component/s: datanode, metrics
• Labels: metrics pull-request-available
• Target Version/s: 3.4.0
• Hadoop Flags: Reviewed
• Assignee: secfree
• Reporter: secfree
• Created: 01/Jan/22 15:55
• Updated: 11/Feb/24 23:32
• Resolved: 09/Feb/22 02:12

Description

The following test case failed. 

  @Test
  public void testNodeLocalMetrics() throws Exception {
    Assume.assumeTrue(null == DomainSocket.getLoadingFailureReason());
    Configuration conf = new HdfsConfiguration();
    conf.setBoolean(HdfsClientConfigKeys.Read.ShortCircuit.KEY, true);
    TemporarySocketDirectory sockDir = new TemporarySocketDirectory();
    DomainSocket.disableBindPathValidation();
    conf.set(DFSConfigKeys.DFS_DOMAIN_SOCKET_PATH_KEY,
        new File(sockDir.getDir(),
            "testNodeLocalMetrics._PORT.sock").getAbsolutePath());
    MiniDFSCluster cluster = new MiniDFSCluster.Builder(conf).numDataNodes(1).build();
    try {
      cluster.waitActive();
      FileSystem fs = cluster.getFileSystem();
      Path testFile = new Path("/testNodeLocalMetrics.txt");
      long file_len = 10;
      DFSTestUtil.createFile(fs, testFile, file_len, (short)1, 1L);
      DFSTestUtil.readFile(fs, testFile);
      List<DataNode> datanodes = cluster.getDataNodes();
      assertEquals(datanodes.size(), 1);
      DataNode datanode = datanodes.get(0);
      MetricsRecordBuilder rb = getMetrics(datanode.getMetrics().name());

      // Write related metrics
      assertCounter("WritesFromLocalClient", 1L, rb);
      // Read related metrics
      assertCounter("ReadsFromLocalClient", 1L, rb); // failed here
    } finally {
      if (cluster != null) {
        cluster.shutdown();
      }
    }
  }

Issue Links

• links to: GitHub Pull Request #3847