[HDFS-16402] Improve HeartbeatManager logic to avoid incorrect stats

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.4.0
• Fix Version/s: 3.4.0
• Component/s: datanode
• Labels: pull-request-available
• Target Version/s: 3.4.0
• Hadoop Flags: Reviewed
• Assignee: Tao Li
• Reporter: Tao Li
• Created: 29/Dec/21 00:20
• Updated: 11/Feb/24 23:28
• Resolved: 24/Jan/22 06:27

Description

After reconfig dfs.datanode.data.dir, we found that the stats of the Namenode Web became negative and there were many NPE in namenode logs. This problem has been solved by HDFS-14042.

However, if HeartbeatManager#updateHeartbeat and HeartbeatManager#updateLifeline throw other exceptions, stats errors can also occur. We should ensure that stats.subtract() and stats.add() are transactional.

Issue Links

• relates to: HDFS-14042 Fix NPE when PROVIDED storage is missing
• links to: GitHub Pull Request #3839