[HDFS-16265] Refactor HDFS tool tests for better reuse

• Type: Improvement
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 3.4.0
• Fix Version/s: 3.4.0
• Component/s: hdfs-client, libhdfs++, tools
• Labels: libhdfscpp pull-request-available

Environment

Centos 7, Centos 8, Debian 10, Ubuntu Focal

• Hadoop Flags: Reviewed
• Flags: Important

Language

C++

• Assignee: Gautham Banasandra Assign to me
• Reporter: Gautham Banasandra
• Due: 15/Oct/21
• Created: 08/Oct/21 18:16
• Updated: 12/Oct/21 04:25
• Resolved: 09/Oct/21 18:01

Description

Currently, the test cases written in hdfs-tool-test.h isn't easy to reuse. Primarily because the expectations are different for each HDFS tool. I realized this while I was creating the PR for HDFS-16260. For instance, passing more than one argument is erroneous to hdfs_allowSnapshot while it's the only valid scenario for hdfs_deleteSnapshot.

Thus, it won't be possible to reuse the test cases without decoupling the expectations from the test case definitions. The solution here is to move the expectations to the corresponding mock classes and invoke the call to set them up in the test cases after the creation of mock instances.

Issue Links

• blocks: HDFS-16260 Make hdfs_deleteSnapshot tool cross platform
• links to: GitHub Pull Request #3536