[HDFS-16242] JournalMetrics should add JournalId MetricTag to distinguish different nameservice journal metrics.

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.4.0
• Fix Version/s: 3.4.0
• Component/s: journal-node
• Labels: pull-request-available
• Hadoop Flags: Reviewed
• Assignee: Max Xie
• Reporter: Max Xie
• Created: 28/Sep/21 10:31
• Updated: 01/Oct/21 07:36
• Resolved: 01/Oct/21 07:36

Description

JournalMetrics should add JournalId MetricTag to distinguish different nameservice journal metrics  when JournalNode use ganglia sink or  prometheus sink.

JMX

Before this patch, journal' jmx :

// jmx json
    {
    "name" : "Hadoop:service=JournalNode,name=Journal-nntest1",
    "Syncs60sNumOps" : 0,
    ...
    },
    {
   "name" : "Hadoop:service=JournalNode,name=Journal-nntest2",
   "Syncs60sNumOps" : 0,
   ... 
   }

 

After this patch, journal' jmx :

 

// jmx json
    {
    "name" : "Hadoop:service=JournalNode,name=Journal-nntest1",
    "tag.JournalId" : "nntest1",  // add this tag
    "Syncs60sNumOps" : 0,
   ...
    },
    {
   "name" : "Hadoop:service=JournalNode,name=Journal-nntest2", 
    "tag.JournalId" : "nntest2",
   "Syncs60sNumOps" : 0,
  ... 
    }

 

PrometheusSink

Before this patch, journal' prometheus export :

 

journal_node_syncs60s_num_ops{context="dfs",hostname="host"} 2

After this patch, journal' prometheus export :

journal_node_syncs60s_num_ops{context="dfs",journalid="nntest2",hostname="host"} 2
journal_node_syncs60s_num_ops{context="dfs",journalid="nntest1",hostname="host"} 75

 

 

 

 

 

 

 

Issue Links

• links to: GitHub Pull Request #3494