Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-16242

JournalMetrics should add JournalId MetricTag to distinguish different nameservice journal metrics.

    XMLWordPrintableJSON

Details

    • Reviewed

    Description

      JournalMetrics should add JournalId MetricTag to distinguish different nameservice journal metrics  when JournalNode use ganglia sink or  prometheus sink.

      JMX

      Before this patch, journal' jmx :

      // jmx json
          {
          "name" : "Hadoop:service=JournalNode,name=Journal-nntest1",
          "Syncs60sNumOps" : 0,
          ...
          },
          {
         "name" : "Hadoop:service=JournalNode,name=Journal-nntest2",
         "Syncs60sNumOps" : 0,
         ... 
         }
      

       

      After this patch, journal' jmx :

       

      // jmx json
          {
          "name" : "Hadoop:service=JournalNode,name=Journal-nntest1",
          "tag.JournalId" : "nntest1",  // add this tag
          "Syncs60sNumOps" : 0,
         ...
          },
          {
         "name" : "Hadoop:service=JournalNode,name=Journal-nntest2", 
          "tag.JournalId" : "nntest2",
         "Syncs60sNumOps" : 0,
        ... 
          }
      

       

      PrometheusSink

      Before this patch, journal' prometheus export :

       

      journal_node_syncs60s_num_ops{context="dfs",hostname="host"} 2
      

      After this patch, journal' prometheus export :

      journal_node_syncs60s_num_ops{context="dfs",journalid="nntest2",hostname="host"} 2
      journal_node_syncs60s_num_ops{context="dfs",journalid="nntest1",hostname="host"} 75
      

       

       

       

       

       

       

       

      Attachments

        Issue Links

          Activity

            People

              max2049 Max Xie
              max2049 Max Xie
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 3.5h
                  3.5h