[HDFS-16233] Do not use exception handler to implement copy-on-write for EnumCounters

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.4.0, 2.10.2, 3.2.3, 3.3.2, 3.1.5
• Component/s: namenode
• Labels: pull-request-available
• Assignee: Wei-Chiu Chuang
• Reporter: Wei-Chiu Chuang
• Created: 22/Sep/21 06:02
• Updated: 28/Sep/21 07:27
• Resolved: 24/Sep/21 16:49

Description

HDFS-14547 saves the NameNode heap space occupied by EnumCounters by essentially implementing a copy-on-write strategy.

At beginning, all EnumCounters refers to the same ConstEnumCounters to save heap space. When it is modified, an exception is thrown and the exception handler converts ConstEnumCounters to EnumCounters object and updates it.

Using exception handler to perform anything more than occasional is bad for performance.

Propose: use instanceof keyword to detect the type of object and do COW accordingly.

Issue Links

• is caused by: HDFS-14547 DirectoryWithQuotaFeature.quota costs additional memory even the storage type quota is not set.
• links to: GitHub Pull Request #3468