Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.22.0
    • Component/s: libhdfs
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Remove AC_TYPE* from the libhdfs build since we get these via stdint.

      Currently configure.ac uses AC_TYPE_INT16_T, AC_TYPE_INT32_T, AC_TYPE_INT64_T and AC_TYPE_UINT16_T and thus requires autoconf 2.61 or higher.
      This prevents using it on such platforms as CentOS/RHEL 5.4 and 5.5. Given that those are pretty popular and also given that it is really difficult to find a platform
      these days that doesn't natively define intXX_t types I'm curious as to whether we can simply remove those macros or perhaps fail ONLY if we happen to be on such
      a platform.

      Here's a link to GNU autoconf docs for your reference:
      http://www.gnu.org/software/hello/manual/autoconf/Particular-Types.html

      1. HDFS-1619-C99.patch.txt
        0.9 kB
        Roman Shaposhnik
      2. hdfs-1619-2.patch
        0.6 kB
        Eli Collins
      3. HDFS-1619.patch.txt
        0.5 kB
        Roman Shaposhnik

        Issue Links

          Activity

          Konstantin Shvachko made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Eli Collins made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Eli Collins made changes -
          Summary Does libhdfs really need to depend on AC_TYPE_INT16_T, AC_TYPE_INT32_T, AC_TYPE_INT64_T and AC_TYPE_UINT16_T ? Remove AC_TYPE* from the libhdfs
          Description Currently configure.ac uses AC_TYPE_INT16_T, AC_TYPE_INT32_T, AC_TYPE_INT64_T and AC_TYPE_UINT16_T and thus requires autoconf 2.61 or higher.
          This prevents using it on such platforms as CentOS/RHEL 5.4 and 5.5. Given that those are pretty popular and also given that it is really difficult to find a platform
          these days that doesn't natively define intXX_t types I'm curious as to whether we can simply remove those macros or perhaps fail ONLY if we happen to be on such
          a platform.

          Here's a link to GNU autoconf docs for your reference:
              http://www.gnu.org/software/hello/manual/autoconf/Particular-Types.html
          Remove AC_TYPE* from the libhdfs build since we get these via stdint.

          Currently configure.ac uses AC_TYPE_INT16_T, AC_TYPE_INT32_T, AC_TYPE_INT64_T and AC_TYPE_UINT16_T and thus requires autoconf 2.61 or higher.
          This prevents using it on such platforms as CentOS/RHEL 5.4 and 5.5. Given that those are pretty popular and also given that it is really difficult to find a platform
          these days that doesn't natively define intXX_t types I'm curious as to whether we can simply remove those macros or perhaps fail ONLY if we happen to be on such
          a platform.

          Here's a link to GNU autoconf docs for your reference:
              http://www.gnu.org/software/hello/manual/autoconf/Particular-Types.html
          Eli Collins made changes -
          Link This issue is related to HDFS-2042 [ HDFS-2042 ]
          Eli Collins made changes -
          Hadoop Flags [Reviewed]
          Assignee Konstantin Shvachko [ shv ] Roman Shaposhnik [ rvs ]
          Fix Version/s 0.22.0 [ 12314241 ]
          Component/s libhdfs [ 12313126 ]
          Roman Shaposhnik made changes -
          Attachment HDFS-1619-C99.patch.txt [ 12481591 ]
          Eli Collins made changes -
          Attachment hdfs-1619-2.patch [ 12481531 ]
          Roman Shaposhnik made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Roman Shaposhnik made changes -
          Field Original Value New Value
          Attachment HDFS-1619.patch.txt [ 12481427 ]
          Roman Shaposhnik created issue -

            People

            • Assignee:
              Roman Shaposhnik
              Reporter:
              Roman Shaposhnik
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development