[HDFS-16118] Improve the number of handlers that initialize NameNodeRpcServer#clientRpcServer

• Type: Improvement
• Status: In Progress
• Priority: Major
• Resolution: Unresolved
• Labels: pull-request-available
• Assignee: JiangHua Zhu
• Reporter: JiangHua Zhu
• Created: 07/Jul/21 08:31
• Updated: 16/Jan/22 01:00

Description

When initializing NameNodeRpcServer, if the value of dfs.namenode.lifeline.handler.count is set to be less than 0 (such as -1, of course, this is rare), when determining the number of lifeline RPC handlers, it will be based on dfs.namenode.handler .count * lifelineHandlerRatio is determined.
The code can be found:
int lifelineHandlerCount = conf.getInt(
DFS_NAMENODE_LIFELINE_HANDLER_COUNT_KEY, 0);
if (lifelineHandlerCount <= 0)

{ float lifelineHandlerRatio = conf.getFloat( DFS_NAMENODE_LIFELINE_HANDLER_RATIO_KEY, DFS_NAMENODE_LIFELINE_HANDLER_RATIO_DEFAULT); lifelineHandlerCount = Math.max( (int)(handlerCount * lifelineHandlerRatio), 1); }

When this happens, the handlerCount should be subtracted from the lifelineHandlerCount when in fact it doesn't.

Issue Links

• links to: GitHub Pull Request #3186