[HDFS-16092] Avoid creating LayoutFlags redundant objects

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.4.0, 3.3.2
• Fix Version/s: 3.4.0, 3.2.3, 3.3.2
• Component/s: hdfs
• Labels: pull-request-available
• Target Version/s: 3.4.0, 3.2.3, 3.3.2
• Hadoop Flags: Reviewed
• Assignee: Viraj Jasani
• Reporter: Viraj Jasani
• Created: 27/Jun/21 12:23
• Updated: 27/Jan/24 02:42
• Resolved: 29/Jun/21 10:13

Description

We use LayoutFlags to represent features that EditLog/FSImage can support. The utility helps write int (0) to given OutputStream and if EditLog/FSImage supports Layout flags, they read the value from InputStream to confirm whether there are unsupported feature flags (non zero int). However, we also create and return new object of LayoutFlags, which is not used anywhere because it's just a utility to read/write to/from given stream. We should remove such redundant objects from getting created while reading from InputStream using LayoutFlags#read utility.

Issue Links

• links to: GitHub Pull Request #3150