[HDFS-16063] Add toString to EditLogFileInputStream

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.4.0
• Fix Version/s: 3.4.0
• Component/s: namenode
• Labels: n00b newbie
• Target Version/s: 3.4.0
• Hadoop Flags: Reviewed
• Assignee: Dionisii Iuzhakov
• Reporter: David Mollitor
• Created: 10/Jun/21 17:18
• Updated: 16/Oct/24 18:29
• Resolved: 23/Sep/21 05:20

Description

The class EditLogFileInputStream is logged at DEBUG level, but has no toString method, so the logging is of limited value. Also, put the DEBUG statement behind some guards since it's printing an unbounded list of items.

https://github.com/apache/hadoop/blob/eefa664fea1119a9c6e3ae2d2ad3069019fbd4ef/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImage.java#L895

Just need the following:

  private final LogSource log;
  private final long firstTxId;
  private final long lastTxId;
  private final boolean isInProgress;
  private int maxOpSize;
  private State state = State.UNINIT;
  private int logVersion = 0;