[HDFS-16042] DatanodeAdminMonitor scan should be delay based

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.4.0, 2.10.2, 3.2.3, 3.3.2
• Component/s: datanode
• Labels: pull-request-available
• Assignee: Ahmed Hussein
• Reporter: Ahmed Hussein
• Created: 26/May/21 20:21
• Updated: 15/Jul/21 21:16
• Resolved: 15/Jul/21 21:16

Description

In DatanodeAdminManager.activate(), the Monitor task is scheduled with a fixed rate, ie. the period is from start1 -> start2.  

executor.scheduleAtFixedRate(monitor, intervalSecs, intervalSecs,
   TimeUnit.SECONDS);

According to Java API docs for scheduleAtFixedRate,

If any execution of this task takes longer than its period, then subsequent executions may start late, but will not concurrently execute.

It should be a fixed delay so it's end1 -> start1.

 

Issue Links

• links to: GitHub Pull Request #3058