[HDFS-16027] HDFS-15245 breaks source code compatibility between 3.3.0 and 3.3.1.

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 3.3.1
• Fix Version/s: 3.3.1
• Component/s: journal-node, ui
• Labels: pull-request-available
• Target Version/s: 3.3.1
• Assignee: Wei-Chiu Chuang
• Reporter: Wei-Chiu Chuang
• Created: 17/May/21 09:07
• Updated: 19/May/21 02:49
• Resolved: 19/May/21 02:49

Description

Ok, this one is on me.

JournalNodeMXBean is a Public, Evolving interface.

But HDFS-15245 was cherrypicked to branch-3.3 which breaks source compatibility between 3.3.0 and 3.3.1 by adding the following three methods:

/**
   * Get host and port of JournalNode.
   *
   * @return colon separated host and port.
   */
  String getHostAndPort();

  /**
   * Get list of the clusters of JournalNode's journals
   * as one JournalNode may support multiple clusters.
   *
   * @return list of clusters.
   */
  List<String> getClusterIds();

  /**
   * Gets the version of Hadoop.
   *
   * @return the version of Hadoop.
   */
  String getVersion();

api checker error:

Recompilation of a client program may be terminated with the message: a client class C is not abstract and does not override abstract method getClusterIds ( ) in JournalNodeMXBean.

Issue Links

• relates to: HADOOP-17671 Run jacc to check for Hadoop's Java API compat
• links to: GitHub Pull Request #3018