Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-1600

editsStored.xml cause release audit warning

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.23.0
    • Component/s: build, test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The file src/test/hdfs/org/apache/hadoop/hdfs/tools/offlineEditsViewer/editsStored.xml for any new patch.

      1. h1600_20110126.patch
        1 kB
        Tsz Wo Nicholas Sze
      2. hadoop-1600.txt
        0.6 kB
        Todd Lipcon

        Activity

        Hide
        Tsz Wo Nicholas Sze added a comment -

        We may either add the license header as shown in h1600_20110126.patch or add editsStored.xml to the exclude list in build.xml.

        Here is the test-patch results of h1600_20110126.patch.

             [exec] -1 overall.  
             [exec] 
             [exec]     +1 @author.  The patch does not contain any @author tags.
             [exec] 
             [exec]     +1 tests included.  The patch appears to include 3 new or modified tests.
             [exec] 
             [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
             [exec] 
             [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
             [exec] 
             [exec]     -1 findbugs.  The patch appears to introduce 200 new Findbugs (version 1.3.9) warnings.
             [exec] 
             [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.
             [exec] 
             [exec]     +1 system test framework.  The patch passed system test framework compile.
        

        Why there are 200 new Findbugs?

        Show
        Tsz Wo Nicholas Sze added a comment - We may either add the license header as shown in h1600_20110126.patch or add editsStored.xml to the exclude list in build.xml. Here is the test-patch results of h1600_20110126.patch. [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 3 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] -1 findbugs. The patch appears to introduce 200 new Findbugs (version 1.3.9) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 system test framework. The patch passed system test framework compile. Why there are 200 new Findbugs?
        Hide
        Tsz Wo Nicholas Sze added a comment -

        > Why there are 200 new Findbugs?

        Created HADOOP-7120.

        Show
        Tsz Wo Nicholas Sze added a comment - > Why there are 200 new Findbugs? Created HADOOP-7120 .
        Hide
        Erik Steffl added a comment -

        As explained in HDFS-1448 (test-patch comment) editsStored.xml should not be changed, it is a reference file for tests (test results are compared to this file). I did not know where to add it for it to be ignored (asked around but it seemed that the test-patch warning can be just ignored, there are other files that also miss the licence).

        Show
        Erik Steffl added a comment - As explained in HDFS-1448 (test-patch comment) editsStored.xml should not be changed, it is a reference file for tests (test results are compared to this file). I did not know where to add it for it to be ignored (asked around but it seemed that the test-patch warning can be just ignored, there are other files that also miss the licence).
        Hide
        Todd Lipcon added a comment -

        here's a patch which just updates the excludes for rat

        Show
        Todd Lipcon added a comment - here's a patch which just updates the excludes for rat
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12470668/hadoop-1600.txt
        against trunk revision 1068725.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 2 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these core unit tests:
        org.apache.hadoop.hdfs.TestFileConcurrentReader

        -1 contrib tests. The patch failed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/155//testReport/
        Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/155//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/155//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12470668/hadoop-1600.txt against trunk revision 1068725. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.hdfs.TestFileConcurrentReader -1 contrib tests. The patch failed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/155//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/155//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/155//console This message is automatically generated.
        Hide
        Tsz Wo Nicholas Sze added a comment -

        +1 patch looks good.

        Show
        Tsz Wo Nicholas Sze added a comment - +1 patch looks good.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #539 (See https://hudson.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/539/)
        HDFS-1600. Fix release audit warnings on trunk. Contributedy by Todd Lipcon

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #539 (See https://hudson.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/539/ ) HDFS-1600 . Fix release audit warnings on trunk. Contributedy by Todd Lipcon
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #643 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/643/)

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #643 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/643/ )

          People

          • Assignee:
            Todd Lipcon
            Reporter:
            Tsz Wo Nicholas Sze
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development