[HDFS-15929] Replace RAND_pseudo_bytes in util.cc

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: 3.4.0
• Component/s: libhdfs++
• Labels: pull-request-available
• Hadoop Flags: Reviewed
• Assignee: Gautham Banasandra
• Reporter: Gautham Banasandra
• Due: 29/Mar/21
• Created: 28/Mar/21 09:00
• Updated: 21/Jan/22 10:55
• Resolved: 30/Mar/21 20:36

Description

RAND_pseudo_bytes was deprecated in OpenSSL 1.1.1. We get the following warning during compilation that it's deprecated -

/mnt/c/Users/Gautham/projects/apache/wsl/hadoop/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/lib/common/util.cc: In function ‘std::string hdfs::GetRandomClientName()’:
/mnt/c/Users/Gautham/projects/apache/wsl/hadoop/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/lib/common/util.cc:78:31: warning: ‘int RAND_pseudo_bytes(unsigned char*, int)’ is deprecated [-Wdeprecated-declarations]
   78 |   RAND_pseudo_bytes(&buf[0], 8);
      |                               ^
In file included from /usr/include/openssl/e_os2.h:13,
                 from /usr/include/openssl/ossl_typ.h:19,
                 from /usr/include/openssl/rand.h:14,
                 from /mnt/c/Users/Gautham/projects/apache/wsl/hadoop/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/lib/common/util.h:29,
                 from /mnt/c/Users/Gautham/projects/apache/wsl/hadoop/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/lib/common/util.cc:19:
/usr/include/openssl/rand.h:44:1: note: declared here
   44 | DEPRECATEDIN_1_1_0(int RAND_pseudo_bytes(unsigned char *buf, int num))
      | ^~~~~~~~~~~~~~~~~~
/mnt/c/Users/Gautham/projects/apache/wsl/hadoop/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/lib/common/util.cc:78:31: warning: ‘int RAND_pseudo_bytes(unsigned char*, int)’ is deprecated [-Wdeprecated-declarations]
   78 |   RAND_pseudo_bytes(&buf[0], 8);
      |                               ^

Issue Links

• is a child of: HDFS-15917 Make HDFS native client more secure
• is related to: HDFS-15918 Replace RAND_pseudo_bytes in sasl_digest_md5.cc
• is related to: HDFS-15928 Replace RAND_pseudo_bytes in rpc_engine.cc
• links to: GitHub Pull Request #2826