[HDFS-15927] Catch polymorphic type by reference

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.4.0
• Component/s: libhdfs++
• Labels: pull-request-available
• Hadoop Flags: Reviewed
• Assignee: Gautham Banasandra
• Reporter: Gautham Banasandra
• Due: 28/Mar/21
• Created: 27/Mar/21 11:48
• Updated: 30/Mar/21 20:39
• Resolved: 30/Mar/21 20:39

Description

Need to catch polymorphic exception types by reference in order to realize the polymorphic usage, if any. Otherwise, the functionality of the caught object is restricted to only that of the base class.

Also, the following warning gets reported since it's currently caught by value -

[WARNING] /home/jenkins/jenkins-agent/workspace/hadoop-multibranch_PR-2792/src/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/lib/common/hdfs_configuration.cc:138:22: warning: catching polymorphic type 'const class hdfs::uri_parse_error' by value [-Wcatch-value=]
[WARNING] /home/jenkins/jenkins-agent/workspace/hadoop-multibranch_PR-2792/src/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/lib/common/hdfs_configuration.cc:151:27: warning: catching polymorphic type 'struct hdfs::ha_parse_error' by value [-Wcatch-value=]

Issue Links

• links to: GitHub Pull Request #2824