Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-1588

Add dfs.hosts.exclude to DFSConfigKeys and use constant in stead of hardcoded string

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.23.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Activity

      Erik Steffl created issue -
      Hide
      Erik Steffl added a comment -

      Also fix the typo:

      ./src/java/org/apache/hadoop/hdfs/tools/GetConf.java: EXCLUDE_FILE("-excludeFile", new CommandHandler("dfs.hosts.exlucde"),

      Show
      Erik Steffl added a comment - Also fix the typo: ./src/java/org/apache/hadoop/hdfs/tools/GetConf.java: EXCLUDE_FILE("-excludeFile", new CommandHandler("dfs.hosts.exlucde"),
      Erik Steffl made changes -
      Field Original Value New Value
      Attachment HDFS-1588-0.23.patch [ 12468931 ]
      Hide
      Erik Steffl added a comment -

      Note about the HDFS-1588-0.23.patch - it does not fix the GetConf.java typo because GetConf.java is not in svn (at this point).

      Show
      Erik Steffl added a comment - Note about the HDFS-1588 -0.23.patch - it does not fix the GetConf.java typo because GetConf.java is not in svn (at this point).
      Hide
      Erik Steffl added a comment -

      ant test-patch results for HDFS-1588-0.23.patch:

      [exec] +1 overall.
      [exec]
      [exec] +1 @author. The patch does not contain any @author tags.
      [exec]
      [exec] +1 tests included. The patch appears to include 13 new or modified tests.
      [exec]
      [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
      [exec]
      [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
      [exec]
      [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
      [exec]
      [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
      [exec]
      [exec] +1 system test framework. The patch passed system test framework compile.

      Show
      Erik Steffl added a comment - ant test-patch results for HDFS-1588 -0.23.patch: [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 13 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 system test framework. The patch passed system test framework compile.
      Hide
      Suresh Srinivas added a comment -

      +1 for the patch.

      Show
      Suresh Srinivas added a comment - +1 for the patch.
      Suresh Srinivas made changes -
      Issue Type Bug [ 1 ] Improvement [ 4 ]
      Hide
      Suresh Srinivas added a comment -

      I committed the patch. Thank you Erik.

      Show
      Suresh Srinivas added a comment - I committed the patch. Thank you Erik.
      Suresh Srinivas made changes -
      Status Open [ 1 ] Resolved [ 5 ]
      Hadoop Flags [Reviewed]
      Resolution Fixed [ 1 ]
      Hide
      Hudson added a comment -

      Integrated in Hadoop-Hdfs-trunk-Commit #539 (See https://hudson.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/539/)

      Show
      Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #539 (See https://hudson.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/539/ )
      Hide
      Hudson added a comment -

      Integrated in Hadoop-Hdfs-trunk #643 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/643/)

      Show
      Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #643 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/643/ )
      Transition Time In Source Status Execution Times Last Executer Last Execution Date
      Open Open Resolved Resolved
      1d 45m 1 Suresh Srinivas 21/Jan/11 20:47

        People

        • Assignee:
          Erik Steffl
          Reporter:
          Erik Steffl
        • Votes:
          0 Vote for this issue
          Watchers:
          1 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development