Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.23.0
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Added a parameter to startDatanodes without maintaining old API

      1. hdfs-1585.txt
        2 kB
        Todd Lipcon

        Issue Links

          Activity

          Hide
          Konstantin Shvachko added a comment -

          Would you care to explain what is broken and how you fix it?

          Show
          Konstantin Shvachko added a comment - Would you care to explain what is broken and how you fix it?
          Hide
          Todd Lipcon added a comment -

          from broken build email:
          [javac] /grid/0/hudson/hudson-slave/workspace/Hadoop-Mapreduce-trunk/trunk/src/test/mapred/org/apache/hadoop/mapred/TestNodeRefresh.java:96: cannot find symbol
          [javac] symbol : method startDataNodes(org.apache.hadoop.conf.Configuration,int,boolean,<nulltype>,<nulltype>,java.lang.String[],<nulltype>)
          [javac] location: class org.apache.hadoop.hdfs.MiniDFSCluster
          [javac] dfs.startDataNodes(conf, numHosts, true, null, null, hosts, null);

          patch adds back call that HDFS-1547 removed.

          Show
          Todd Lipcon added a comment - from broken build email: [javac] /grid/0/hudson/hudson-slave/workspace/Hadoop-Mapreduce-trunk/trunk/src/test/mapred/org/apache/hadoop/mapred/TestNodeRefresh.java:96: cannot find symbol [javac] symbol : method startDataNodes(org.apache.hadoop.conf.Configuration,int,boolean,<nulltype>,<nulltype>,java.lang.String[],<nulltype>) [javac] location: class org.apache.hadoop.hdfs.MiniDFSCluster [javac] dfs.startDataNodes(conf, numHosts, true, null, null, hosts, null); patch adds back call that HDFS-1547 removed.
          Hide
          Eli Collins added a comment -

          +1

          Show
          Eli Collins added a comment - +1
          Hide
          Todd Lipcon added a comment -

          Committed, thanks Eli.

          Show
          Todd Lipcon added a comment - Committed, thanks Eli.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12468773/hdfs-1585.txt
          against trunk revision 1060655.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these core unit tests:
          org.apache.hadoop.hdfs.server.namenode.TestLargeDirectoryDelete
          org.apache.hadoop.hdfs.server.namenode.TestStorageRestore

          -1 contrib tests. The patch failed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/123//testReport/
          Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/123//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/123//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12468773/hdfs-1585.txt against trunk revision 1060655. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.hdfs.server.namenode.TestLargeDirectoryDelete org.apache.hadoop.hdfs.server.namenode.TestStorageRestore -1 contrib tests. The patch failed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/123//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/123//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/123//console This message is automatically generated.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          Todd, thanks for fixing this.

          Show
          Tsz Wo Nicholas Sze added a comment - Todd, thanks for fixing this.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #643 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/643/)

          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #643 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/643/ )

            People

            • Assignee:
              Todd Lipcon
              Reporter:
              Todd Lipcon
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development