[HDFS-15818] Fix TestFsDatasetImpl.testReadLockCanBeDisabledByConfig

• Type: Sub-task
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.4.0
• Fix Version/s: 3.4.0, 3.2.3, 3.2.4
• Component/s: test
• Labels: pull-request-available
• Target Version/s: 3.4.0
• Hadoop Flags: Reviewed
• Assignee: Leon Gao
• Reporter: Leon Gao
• Created: 04/Feb/21 01:15
• Updated: 27/Jan/24 02:53
• Resolved: 09/Feb/21 10:50

Description

Current TestFsDatasetImpl.testReadLockCanBeDisabledByConfig is incorrect:

1) Test fails intermittently as holder can acquire lock first

https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2666/1/testReport/

 

2) Test passes regardless of the setting of 

DFS_DATANODE_LOCK_READ_WRITE_ENABLED_KEY

Issue Links

• is caused by: HDFS-15160 ReplicaMap, Disk Balancer, Directory Scanner and various FsDatasetImpl methods should use datanode readlock
• links to: GitHub Pull Request #2679