Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.22.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      DatanodeJspHelper seems to expect the file path to be in the "path info" of the HttpRequest, rather than in a parameter. I see the following exception when visiting the URL http://localhost.localdomain:50075/browseBlock.jsp?blockId=5006108823351810567&blockSize=20&genstamp=1001&filename=%2Fuser%2Ftodd%2Fissue&datanodePort=50010&namenodeInfoPort=50070

      java.io.FileNotFoundException: File does not exist: /
      at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.getBlockLocationsInternal(FSNamesystem.java:834)
      ...
      at org.apache.hadoop.hdfs.server.datanode.DatanodeJspHelper.generateFileDetails(DatanodeJspHelper.java:258)
      at org.apache.hadoop.hdfs.server.datanode.browseBlock_jsp._jspService(browseBlock_jsp.java:79)
      at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:97)

      1. HDFS-1575
        1 kB
        Dmytro Molkov
      2. hdfs-1575-22.0.patch
        10 kB
        Aaron T. Myers
      3. hdfs-1575-trunk.0.patch
        5 kB
        Aaron T. Myers
      4. hdfs-1575-trunk.1.patch
        9 kB
        Aaron T. Myers
      5. hdfs-1575-trunk.2.patch
        10 kB
        Aaron T. Myers
      6. hdfs-1575-trunk.3.patch
        10 kB
        Todd Lipcon

        Issue Links

          Activity

          Todd Lipcon created issue -
          Hide
          Jakob Homan added a comment -

          This bug was identified in HDFS-1109 (http://s.apache.org/D2i), but I don't see that a JIRA was ever opened for it. Suresh? Dmytro?

          Show
          Jakob Homan added a comment - This bug was identified in HDFS-1109 ( http://s.apache.org/D2i ), but I don't see that a JIRA was ever opened for it. Suresh? Dmytro?
          Jakob Homan made changes -
          Field Original Value New Value
          Link This issue is broken by HDFS-1109 [ HDFS-1109 ]
          Hide
          Nigel Daley added a comment -

          Suresh, can you look at this issue?

          Show
          Nigel Daley added a comment - Suresh, can you look at this issue?
          Hide
          Suresh Srinivas added a comment -

          I had asked Dmytro to look at it. He agreed to in HDFS-1109. Dmytro do you have any update?

          Show
          Suresh Srinivas added a comment - I had asked Dmytro to look at it. He agreed to in HDFS-1109 . Dmytro do you have any update?
          Hide
          Dmytro Molkov added a comment -

          This patch fixes the problem.
          I just tested it locally and I can still execute hftp commands and browse the filesystem.
          Please take a look guys

          Show
          Dmytro Molkov added a comment - This patch fixes the problem. I just tested it locally and I can still execute hftp commands and browse the filesystem. Please take a look guys
          Dmytro Molkov made changes -
          Attachment HDFS-1575 [ 12476499 ]
          Hide
          Dmytro Molkov added a comment -

          I guess I should also do url unencode if I fetch the value from the filename parameter, shouldn't I?

          The original patch in 1109 was fixing the problem with certain characters that were not handled correctly when passed around in the request parameter. Unfortunately I did not take into account the fact that we have jsp files being used for this at the same time.

          Show
          Dmytro Molkov added a comment - I guess I should also do url unencode if I fetch the value from the filename parameter, shouldn't I? The original patch in 1109 was fixing the problem with certain characters that were not handled correctly when passed around in the request parameter. Unfortunately I did not take into account the fact that we have jsp files being used for this at the same time.
          Hide
          Dmytro Molkov added a comment -

          Just looked at the original patch and there is no URL decoding, so with this patch the behaviour is exactly like the one before 1109 if the path is passed via the filename parameter, and also works when the path is passed as a part of PathInfo to the servlet.

          Show
          Dmytro Molkov added a comment - Just looked at the original patch and there is no URL decoding, so with this patch the behaviour is exactly like the one before 1109 if the path is passed via the filename parameter, and also works when the path is passed as a part of PathInfo to the servlet.
          Hide
          Dmytro Molkov added a comment -

          Submitting patch.
          Please have a look, there is no test with it since it modifies the web ui behaviour.

          Show
          Dmytro Molkov added a comment - Submitting patch. Please have a look, there is no test with it since it modifies the web ui behaviour.
          Dmytro Molkov made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12476499/HDFS-1575
          against trunk revision 1094748.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these core unit tests:
          org.apache.hadoop.hdfs.server.datanode.TestBlockReport
          org.apache.hadoop.hdfs.TestFileConcurrentReader

          -1 contrib tests. The patch failed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/390//testReport/
          Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/390//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/390//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12476499/HDFS-1575 against trunk revision 1094748. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.hdfs.server.datanode.TestBlockReport org.apache.hadoop.hdfs.TestFileConcurrentReader -1 contrib tests. The patch failed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/390//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/390//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/390//console This message is automatically generated.
          Hide
          Todd Lipcon added a comment -

          A few issues with the patch:

          • style issue: need braces around the if () {...}

            block

          • style issue: continuation of line "path = req.getPathInfo()..." should be indented
          • The filename that gets put onto the path needs to get path-encoded. Right now there is an XSS vulnerability if you name a file something like '">...evilcodehere...'. Note that path-encoding is different than URLEncoding - particularly in that "/" should not be encoded, and " " turns to "%20" instead of "+".
          Show
          Todd Lipcon added a comment - A few issues with the patch: style issue: need braces around the if () {...} block style issue: continuation of line "path = req.getPathInfo()..." should be indented The filename that gets put onto the path needs to get path-encoded. Right now there is an XSS vulnerability if you name a file something like '">...evilcodehere...'. Note that path-encoding is different than URLEncoding - particularly in that "/" should not be encoded, and " " turns to "%20" instead of "+".
          Hide
          Eli Collins added a comment -

          Dmytro - mind updating the patch to address Todd's feedback?

          Show
          Eli Collins added a comment - Dmytro - mind updating the patch to address Todd's feedback?
          Eli Collins made changes -
          Assignee Dmytro Molkov [ dms ]
          Omer Trajman made changes -
          Link This issue blocks HDFS-1579 [ HDFS-1579 ]
          Hide
          Aaron T. Myers added a comment -

          Patch which addresses Todd's comments and fixes two bugs introduced by the HDFS-1052 merge.

          Show
          Aaron T. Myers added a comment - Patch which addresses Todd's comments and fixes two bugs introduced by the HDFS-1052 merge.
          Aaron T. Myers made changes -
          Attachment hdfs-1575-trunk.0.patch [ 12479658 ]
          Aaron T. Myers made changes -
          Assignee Dmytro Molkov [ dms ] Aaron T. Myers [ atm ]
          Hide
          Todd Lipcon added a comment -

          Since these changes are just in the java, it seems we could have some true unit tests for it?
          Also, when concatenating "val" in the getUrlParam functions, shouldn't it be encoded?

          Show
          Todd Lipcon added a comment - Since these changes are just in the java, it seems we could have some true unit tests for it? Also, when concatenating "val" in the getUrlParam functions, shouldn't it be encoded?
          Hide
          Aaron T. Myers added a comment -

          Since these changes are just in the java, it seems we could have some true unit tests for it?

          Sure could. I'll work on that.

          Also, when concatenating "val" in the getUrlParam functions, shouldn't it be encoded?

          Maybe. I'm not sure that the URL encoding should be done at this level. Regardless, it has the potential to break a lot of stuff via double-encoding, so I'd rather do that as part of a separate JIRA, if it's alright with you.

          Show
          Aaron T. Myers added a comment - Since these changes are just in the java, it seems we could have some true unit tests for it? Sure could. I'll work on that. Also, when concatenating "val" in the getUrlParam functions, shouldn't it be encoded? Maybe. I'm not sure that the URL encoding should be done at this level. Regardless, it has the potential to break a lot of stuff via double-encoding, so I'd rather do that as part of a separate JIRA, if it's alright with you.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12479658/hdfs-1575-trunk.0.patch
          against trunk revision 1124364.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these core unit tests:
          org.apache.hadoop.hdfs.server.datanode.TestBlockReplacement
          org.apache.hadoop.hdfs.TestDFSStorageStateRecovery
          org.apache.hadoop.hdfs.TestFileConcurrentReader
          org.apache.hadoop.tools.TestJMXGet

          +1 contrib tests. The patch passed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/565//testReport/
          Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/565//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/565//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12479658/hdfs-1575-trunk.0.patch against trunk revision 1124364. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.hdfs.server.datanode.TestBlockReplacement org.apache.hadoop.hdfs.TestDFSStorageStateRecovery org.apache.hadoop.hdfs.TestFileConcurrentReader org.apache.hadoop.tools.TestJMXGet +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/565//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/565//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/565//console This message is automatically generated.
          Hide
          Aaron T. Myers added a comment -

          Updated patch addressing Todd's comments by adding a test. Also found/fixed a bug wherein files with special characters could not be viewed via the web UI.

          Show
          Aaron T. Myers added a comment - Updated patch addressing Todd's comments by adding a test. Also found/fixed a bug wherein files with special characters could not be viewed via the web UI.
          Aaron T. Myers made changes -
          Attachment hdfs-1575-trunk.1.patch [ 12479703 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12479703/hdfs-1575-trunk.1.patch
          against trunk revision 1124459.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 5 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          -1 release audit. The applied patch generated 1 release audit warnings (more than the trunk's current 0 warnings).

          -1 core tests. The patch failed these core unit tests:
          org.apache.hadoop.hdfs.TestDFSStorageStateRecovery
          org.apache.hadoop.hdfs.TestFileConcurrentReader
          org.apache.hadoop.tools.TestJMXGet

          +1 contrib tests. The patch passed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/577//testReport/
          Release audit warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/577//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
          Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/577//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/577//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12479703/hdfs-1575-trunk.1.patch against trunk revision 1124459. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 5 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. -1 release audit. The applied patch generated 1 release audit warnings (more than the trunk's current 0 warnings). -1 core tests. The patch failed these core unit tests: org.apache.hadoop.hdfs.TestDFSStorageStateRecovery org.apache.hadoop.hdfs.TestFileConcurrentReader org.apache.hadoop.tools.TestJMXGet +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/577//testReport/ Release audit warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/577//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/577//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/577//console This message is automatically generated.
          Hide
          Todd Lipcon added a comment -

          Looks like license header is missing on TestDatanodeJsp

          Show
          Todd Lipcon added a comment - Looks like license header is missing on TestDatanodeJsp
          Hide
          Aaron T. Myers added a comment -

          Patch adding license header to TestDatanodeJsp.java.

          Show
          Aaron T. Myers added a comment - Patch adding license header to TestDatanodeJsp.java.
          Aaron T. Myers made changes -
          Attachment hdfs-1575-trunk.2.patch [ 12479722 ]
          Hide
          Todd Lipcon added a comment -

          Hi Aaron. I noticed some opportunity for cleanup here:

          • removed unused import of org.mortbay.Log
          • cleaned up the JSP so there isn't duplicated code
          • the case that blks == null or blks.size() == 0 and security was off was being handled incorrectly
          • fixed a line that was super long

          Can you take a look at my changes?

          Show
          Todd Lipcon added a comment - Hi Aaron. I noticed some opportunity for cleanup here: removed unused import of org.mortbay.Log cleaned up the JSP so there isn't duplicated code the case that blks == null or blks.size() == 0 and security was off was being handled incorrectly fixed a line that was super long Can you take a look at my changes?
          Todd Lipcon made changes -
          Attachment hdfs-1575-trunk.3.patch [ 12479729 ]
          Hide
          Aaron T. Myers added a comment -

          +1, looks good to me. I especially like the reworking of the loop which iterates over blks. Thanks for cleaning this up.

          Show
          Aaron T. Myers added a comment - +1, looks good to me. I especially like the reworking of the loop which iterates over blks . Thanks for cleaning this up.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12479722/hdfs-1575-trunk.2.patch
          against trunk revision 1124459.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 5 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these core unit tests:
          org.apache.hadoop.hdfs.TestDFSStorageStateRecovery
          org.apache.hadoop.hdfs.TestFileConcurrentReader
          org.apache.hadoop.tools.TestJMXGet

          +1 contrib tests. The patch passed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/582//testReport/
          Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/582//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/582//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12479722/hdfs-1575-trunk.2.patch against trunk revision 1124459. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 5 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.hdfs.TestDFSStorageStateRecovery org.apache.hadoop.hdfs.TestFileConcurrentReader org.apache.hadoop.tools.TestJMXGet +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/582//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/582//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/582//console This message is automatically generated.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12479729/hdfs-1575-trunk.3.patch
          against trunk revision 1124459.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 6 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these core unit tests:
          org.apache.hadoop.hdfs.TestDFSStorageStateRecovery
          org.apache.hadoop.hdfs.TestFileConcurrentReader
          org.apache.hadoop.hdfs.TestHDFSTrash
          org.apache.hadoop.hdfs.TestPipelines
          org.apache.hadoop.tools.TestJMXGet

          +1 contrib tests. The patch passed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/585//testReport/
          Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/585//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/585//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12479729/hdfs-1575-trunk.3.patch against trunk revision 1124459. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.hdfs.TestDFSStorageStateRecovery org.apache.hadoop.hdfs.TestFileConcurrentReader org.apache.hadoop.hdfs.TestHDFSTrash org.apache.hadoop.hdfs.TestPipelines org.apache.hadoop.tools.TestJMXGet +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/585//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/585//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/585//console This message is automatically generated.
          Hide
          Todd Lipcon added a comment -

          I tried the failing tests locally and they pass. Will commit to 22 and trunk momentarily.

          Show
          Todd Lipcon added a comment - I tried the failing tests locally and they pass. Will commit to 22 and trunk momentarily.
          Hide
          Todd Lipcon added a comment -

          Committed to trunk. Looks like we need to alter the patch a little for 0.22 since the federation stuff isn't there. Mind doing that?

          Show
          Todd Lipcon added a comment - Committed to trunk. Looks like we need to alter the patch a little for 0.22 since the federation stuff isn't there. Mind doing that?
          Hide
          Aaron T. Myers added a comment -

          What's attached is a faithful back-port of the trunk commit. In the course of doing this back-port I identified a bug, which I've filed under HDFS-1964. Let's commit this patch to branch-0.22 and then I'll back-port the bug fix.

          Show
          Aaron T. Myers added a comment - What's attached is a faithful back-port of the trunk commit. In the course of doing this back-port I identified a bug, which I've filed under HDFS-1964 . Let's commit this patch to branch-0.22 and then I'll back-port the bug fix.
          Aaron T. Myers made changes -
          Attachment hdfs-1575-22.0.patch [ 12479841 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12479841/hdfs-1575-22.0.patch
          against trunk revision 1125057.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 5 new or modified tests.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/593//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12479841/hdfs-1575-22.0.patch against trunk revision 1125057. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 5 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/593//console This message is automatically generated.
          Aaron T. Myers made changes -
          Link This issue blocks HDFS-1964 [ HDFS-1964 ]
          Hide
          Todd Lipcon added a comment -

          Thanks for the 0.22 patch. Committed it.

          Show
          Todd Lipcon added a comment - Thanks for the 0.22 patch. Committed it.
          Todd Lipcon made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Hadoop Flags [Reviewed]
          Resolution Fixed [ 1 ]
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #677 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/677/)

          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #677 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/677/ )
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-22-branch #53 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-22-branch/53/)

          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-22-branch #53 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-22-branch/53/ )
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #673 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/673/)

          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #673 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/673/ )
          Eli Collins made changes -
          Link This issue is blocked by HDFS-1109 [ HDFS-1109 ]
          Konstantin Shvachko made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Gavin made changes -
          Link This issue blocks HDFS-1579 [ HDFS-1579 ]
          Gavin made changes -
          Link This issue is depended upon by HDFS-1579 [ HDFS-1579 ]
          Gavin made changes -
          Link This issue blocks HDFS-1964 [ HDFS-1964 ]
          Gavin made changes -
          Link This issue is depended upon by HDFS-1964 [ HDFS-1964 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Patch Available Patch Available
          98d 7h 45m 1 Dmytro Molkov 19/Apr/11 07:42
          Patch Available Patch Available Resolved Resolved
          30d 20h 31m 1 Todd Lipcon 20/May/11 04:14
          Resolved Resolved Closed Closed
          206d 3h 5m 1 Konstantin Shvachko 12/Dec/11 06:19

            People

            • Assignee:
              Aaron T. Myers
              Reporter:
              Todd Lipcon
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development