[HDFS-15515] mkdirs on fallback should throw IOE out instead of suppressing and returning false

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.2.2, 3.3.1
• Target Version/s: 3.4.0
• Hadoop Flags: Reviewed
• Assignee: Uma Maheswara Rao G
• Reporter: Uma Maheswara Rao G
• Created: 06/Aug/20 06:09
• Updated: 10/Jun/21 07:44
• Resolved: 12/Aug/20 02:54

Description

Currently when doing mkdirs on fallback dir, we catching IOE and returning false.
I think we should just throw IOE out as the fs#mkdirs throws IOE out.

I noticed a case when we attempt to create .reserved dirs, NN throws HadoopIAE.
But we will catch and return false. Here exception should be thrown out.

try {
          return linkedFallbackFs.mkdirs(dirToCreate, permission);
        } catch (IOException e) {
          if (LOG.isDebugEnabled()) {
            StringBuilder msg =
                new StringBuilder("Failed to create ").append(dirToCreate)
                    .append(" at fallback : ")
                    .append(linkedFallbackFs.getUri());
            LOG.debug(msg.toString(), e);
          }
          return false;
        }

Issue Links

• links to: GitHub Pull Request #2205