Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-15289 Allow viewfs mounts with HDFS/HCFS scheme and centralized mount table
  3. HDFS-15515

mkdirs on fallback should throw IOE out instead of suppressing and returning false

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 3.2.2, 3.3.1
    • None
    • None
    • Reviewed

    Description

      Currently when doing mkdirs on fallback dir, we catching IOE and returning false.
      I think we should just throw IOE out as the fs#mkdirs throws IOE out.

      I noticed a case when we attempt to create .reserved dirs, NN throws HadoopIAE.
      But we will catch and return false. Here exception should be thrown out.

      try {
                return linkedFallbackFs.mkdirs(dirToCreate, permission);
              } catch (IOException e) {
                if (LOG.isDebugEnabled()) {
                  StringBuilder msg =
                      new StringBuilder("Failed to create ").append(dirToCreate)
                          .append(" at fallback : ")
                          .append(linkedFallbackFs.getUri());
                  LOG.debug(msg.toString(), e);
                }
                return false;
              }
      

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            umamaheswararao Uma Maheswara Rao G
            umamaheswararao Uma Maheswara Rao G
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment