[HDFS-15270] Account for *env == NULL in hdfsThreadDestructor

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.2.2, 3.3.1, 3.4.0
• Fix Version/s: 3.2.2, 3.3.1, 3.4.0
• Component/s: libhdfs

Environment

Please refer to the "steps to reproduce" the failure in https://github.com/eclipse/openj9/issues/7752#issue-521732953.

• Target Version/s: 3.2.2, 3.3.1, 3.4.0
• Hadoop Flags: Reviewed
• Assignee: Babneet Singh
• Reporter: Babneet Singh
• Created: 10/Apr/20 17:31
• Updated: 11/Feb/24 12:32
• Resolved: 04/May/20 20:10

Description

OpenJ9 JVM properly terminates the thread before hdfsThreadDestructor is
invoked. JNIEnv is a mirror of J9VMThread in OpenJ9. After proper thread
termination, accessing JNIEnv in hdfsThreadDestructor (*env)->GetJavaVM,
yields a SIGSEGV since *env is NULL after thread cleanup is performed.

The main purpose of hdfsThreadDestructor is to invoke
DetachCurrentThread, which performs thread cleanup in OpenJ9. Since
OpenJ9 performs thread cleanup before hdfsThreadDestructor is invoked,
hdfsThreadDestructor should account for *env == NULL and skip
DetachCurrentThread.

Issue Links

• links to: GitHub Pull Request #1951