Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-15198

RBF: Add test for MountTableRefresherService failed to refresh other router MountTableEntries in secure mode

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 3.3.1, 3.4.0
    • rbf
    • None
    • Reviewed

    Description

      In issue HDFS-13443, update mount table cache imediately. The specified router update their own mount table cache imediately, then update other's by rpc protocol refreshMountTableEntries. But in secure mode, can't refresh other's router's. In specified router's log, error like this

      2020-02-27 22:59:07,212 WARN org.apache.hadoop.ipc.Client: Exception encountered while connecting to the server : javax.security.sasl.SaslException: GSS initiate failed [Caused by GSSException: No valid credentials provided (Mechanism level: Failed to find any Kerberos tgt)]
      2020-02-27 22:59:07,213 ERROR org.apache.hadoop.hdfs.server.federation.router.MountTableRefresherThread: Failed to refresh mount table entries cache at router $host:8111
      java.io.IOException: DestHost:destPort host:8111 , LocalHost:localPort $host/$ip:0. Failed on local exception: java.io.IOException: javax.security.sasl.SaslException: GSS initiate failed [Caused by GSSException: No valid credentials provided (Mechanism level: Failed to find any Kerberos tgt)]
      at org.apache.hadoop.hdfs.protocolPB.RouterAdminProtocolTranslatorPB.refreshMountTableEntries(RouterAdminProtocolTranslatorPB.java:288)
      at org.apache.hadoop.hdfs.server.federation.router.MountTableRefresherThread.run(MountTableRefresherThread.java:65)
      2020-02-27 22:59:07,214 INFO org.apache.hadoop.hdfs.server.federation.resolver.MountTableResolver: Added new mount point /test_11 to resolver
      
      

      Attachments

        1. HDFS-15198.001.patch
          1.0 kB
          Chenyu Zheng
        2. HDFS-15198.002.patch
          20 kB
          Chenyu Zheng
        3. HDFS-15198.003.patch
          20 kB
          Chenyu Zheng
        4. HDFS-15198.004.patch
          15 kB
          Chenyu Zheng
        5. HDFS-15198.005.patch
          14 kB
          Chenyu Zheng
        6. HDFS-15198.006.patch
          15 kB
          Chenyu Zheng

        Issue Links

          Activity

            ayushtkn Ayush Saxena added a comment -

            Thanx zhengchenyu  for the report.

            Do you want to contribute a fix?

            ayushtkn Ayush Saxena added a comment - Thanx zhengchenyu   for the report. Do you want to contribute a fix?
            hadoopqa Hadoop QA added a comment -
            -1 overall



            Vote Subsystem Runtime Comment
            0 reexec 0m 56s Docker mode activated.
                  Prechecks
            +1 @author 0m 0s The patch does not contain any @author tags.
            -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
                  trunk Compile Tests
            +1 mvninstall 20m 13s trunk passed
            +1 compile 0m 30s trunk passed
            +1 checkstyle 0m 20s trunk passed
            +1 mvnsite 0m 33s trunk passed
            +1 shadedclient 15m 42s branch has no errors when building and testing our client artifacts.
            +1 findbugs 1m 17s trunk passed
            +1 javadoc 0m 37s trunk passed
                  Patch Compile Tests
            +1 mvninstall 0m 31s the patch passed
            +1 compile 0m 29s the patch passed
            +1 javac 0m 29s the patch passed
            +1 checkstyle 0m 17s the patch passed
            +1 mvnsite 0m 30s the patch passed
            +1 whitespace 0m 0s The patch has no whitespace issues.
            +1 shadedclient 14m 34s patch has no errors when building and testing our client artifacts.
            +1 findbugs 1m 7s the patch passed
            +1 javadoc 0m 27s the patch passed
                  Other Tests
            +1 unit 8m 1s hadoop-hdfs-rbf in the patch passed.
            +1 asflicense 0m 28s The patch does not generate ASF License warnings.
            67m 40s



            Subsystem Report/Notes
            Docker Client=19.03.6 Server=19.03.6 Image:yetus/hadoop:c44943d1fc3
            JIRA Issue HDFS-15198
            JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12994834/HDFS-15198.001.patch
            Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
            uname Linux a40d25b771f2 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
            Build tool maven
            Personality /testptch/patchprocess/precommit/personality/provided.sh
            git revision trunk / a43510e
            maven version: Apache Maven 3.3.9
            Default Java 1.8.0_242
            findbugs v3.1.0-RC1
            Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/28870/testReport/
            Max. process+thread count 3192 (vs. ulimit of 5500)
            modules C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf
            Console output https://builds.apache.org/job/PreCommit-HDFS-Build/28870/console
            Powered by Apache Yetus 0.8.0 http://yetus.apache.org

            This message was automatically generated.

            hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 56s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       trunk Compile Tests +1 mvninstall 20m 13s trunk passed +1 compile 0m 30s trunk passed +1 checkstyle 0m 20s trunk passed +1 mvnsite 0m 33s trunk passed +1 shadedclient 15m 42s branch has no errors when building and testing our client artifacts. +1 findbugs 1m 17s trunk passed +1 javadoc 0m 37s trunk passed       Patch Compile Tests +1 mvninstall 0m 31s the patch passed +1 compile 0m 29s the patch passed +1 javac 0m 29s the patch passed +1 checkstyle 0m 17s the patch passed +1 mvnsite 0m 30s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 shadedclient 14m 34s patch has no errors when building and testing our client artifacts. +1 findbugs 1m 7s the patch passed +1 javadoc 0m 27s the patch passed       Other Tests +1 unit 8m 1s hadoop-hdfs-rbf in the patch passed. +1 asflicense 0m 28s The patch does not generate ASF License warnings. 67m 40s Subsystem Report/Notes Docker Client=19.03.6 Server=19.03.6 Image:yetus/hadoop:c44943d1fc3 JIRA Issue HDFS-15198 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12994834/HDFS-15198.001.patch Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle uname Linux a40d25b771f2 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/patchprocess/precommit/personality/provided.sh git revision trunk / a43510e maven version: Apache Maven 3.3.9 Default Java 1.8.0_242 findbugs v3.1.0-RC1 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/28870/testReport/ Max. process+thread count 3192 (vs. ulimit of 5500) modules C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf Console output https://builds.apache.org/job/PreCommit-HDFS-Build/28870/console Powered by Apache Yetus 0.8.0 http://yetus.apache.org This message was automatically generated.
            ayushtkn Ayush Saxena added a comment -

            Can you extend a test for this?

            ayushtkn Ayush Saxena added a comment - Can you extend a test for this?
            hadoopqa Hadoop QA added a comment -
            -1 overall



            Vote Subsystem Runtime Comment
            0 reexec 0m 0s Docker mode activated.
            -1 patch 0m 7s HDFS-15198 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



            This message was automatically generated.

            hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 7s HDFS-15198 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Issue HDFS-15198 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12995051/HDFS-15198.002.patch Console output https://builds.apache.org/job/PreCommit-HDFS-Build/28882/console Powered by Apache Yetus 0.8.0 http://yetus.apache.org This message was automatically generated.
            hadoopqa Hadoop QA added a comment -
            +1 overall



            Vote Subsystem Runtime Comment
            0 reexec 0m 48s Docker mode activated.
                  Prechecks
            +1 @author 0m 0s The patch does not contain any @author tags.
            +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
                  trunk Compile Tests
            +1 mvninstall 19m 26s trunk passed
            +1 compile 0m 29s trunk passed
            +1 checkstyle 0m 18s trunk passed
            +1 mvnsite 0m 32s trunk passed
            +1 shadedclient 15m 6s branch has no errors when building and testing our client artifacts.
            +1 findbugs 1m 10s trunk passed
            +1 javadoc 0m 28s trunk passed
                  Patch Compile Tests
            +1 mvninstall 0m 29s the patch passed
            +1 compile 0m 25s the patch passed
            +1 javac 0m 25s the patch passed
            -0 checkstyle 0m 17s hadoop-hdfs-project/hadoop-hdfs-rbf: The patch generated 202 new + 0 unchanged - 0 fixed = 202 total (was 0)
            +1 mvnsite 0m 29s the patch passed
            +1 whitespace 0m 0s The patch has no whitespace issues.
            +1 shadedclient 14m 44s patch has no errors when building and testing our client artifacts.
            +1 findbugs 1m 24s the patch passed
            +1 javadoc 0m 29s the patch passed
                  Other Tests
            +1 unit 9m 4s hadoop-hdfs-rbf in the patch passed.
            +1 asflicense 0m 31s The patch does not generate ASF License warnings.
            67m 18s



            Subsystem Report/Notes
            Docker Client=19.03.6 Server=19.03.6 Image:yetus/hadoop:c44943d1fc3
            JIRA Issue HDFS-15198
            JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12995052/HDFS-15198.003.patch
            Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
            uname Linux 7470875fbbff 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
            Build tool maven
            Personality /testptch/patchprocess/precommit/personality/provided.sh
            git revision trunk / 1a636da
            maven version: Apache Maven 3.3.9
            Default Java 1.8.0_242
            findbugs v3.1.0-RC1
            checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/28883/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
            Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/28883/testReport/
            Max. process+thread count 3462 (vs. ulimit of 5500)
            modules C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf
            Console output https://builds.apache.org/job/PreCommit-HDFS-Build/28883/console
            Powered by Apache Yetus 0.8.0 http://yetus.apache.org

            This message was automatically generated.

            hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 48s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.       trunk Compile Tests +1 mvninstall 19m 26s trunk passed +1 compile 0m 29s trunk passed +1 checkstyle 0m 18s trunk passed +1 mvnsite 0m 32s trunk passed +1 shadedclient 15m 6s branch has no errors when building and testing our client artifacts. +1 findbugs 1m 10s trunk passed +1 javadoc 0m 28s trunk passed       Patch Compile Tests +1 mvninstall 0m 29s the patch passed +1 compile 0m 25s the patch passed +1 javac 0m 25s the patch passed -0 checkstyle 0m 17s hadoop-hdfs-project/hadoop-hdfs-rbf: The patch generated 202 new + 0 unchanged - 0 fixed = 202 total (was 0) +1 mvnsite 0m 29s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 shadedclient 14m 44s patch has no errors when building and testing our client artifacts. +1 findbugs 1m 24s the patch passed +1 javadoc 0m 29s the patch passed       Other Tests +1 unit 9m 4s hadoop-hdfs-rbf in the patch passed. +1 asflicense 0m 31s The patch does not generate ASF License warnings. 67m 18s Subsystem Report/Notes Docker Client=19.03.6 Server=19.03.6 Image:yetus/hadoop:c44943d1fc3 JIRA Issue HDFS-15198 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12995052/HDFS-15198.003.patch Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle uname Linux 7470875fbbff 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/patchprocess/precommit/personality/provided.sh git revision trunk / 1a636da maven version: Apache Maven 3.3.9 Default Java 1.8.0_242 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/28883/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs-rbf.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/28883/testReport/ Max. process+thread count 3462 (vs. ulimit of 5500) modules C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf Console output https://builds.apache.org/job/PreCommit-HDFS-Build/28883/console Powered by Apache Yetus 0.8.0 http://yetus.apache.org This message was automatically generated.
            ayushtkn Ayush Saxena added a comment -

            Seems the test is almost copy of TestRouterMountTableCacheRefresh
            Rather than copying all the tests in new class, can you make the new class extend TestRouterMountTableCacheRefresh and Override the methods you want to change, the common methods can be prevented from being copied.

            ayushtkn Ayush Saxena added a comment - Seems the test is almost copy of TestRouterMountTableCacheRefresh Rather than copying all the tests in new class, can you make the new class extend TestRouterMountTableCacheRefresh and Override the methods you want to change, the common methods can be prevented from being copied.
            zhengchenyu Chenyu Zheng added a comment -

            ayushtkn This patch just want to test TestRouterMountTableCacheRefresh in secure mode, so Copy from this class. In setUp function, you will see initSecurity for security initialization and configuration. 

            zhengchenyu Chenyu Zheng added a comment - ayushtkn  This patch just want to test TestRouterMountTableCacheRefresh in secure mode, so Copy from this class. In setUp function, you will see initSecurity for security initialization and configuration. 
            elgoiri Íñigo Goiri added a comment -

            We should do some refactoring instead of just having the same code in multiple places.

            elgoiri Íñigo Goiri added a comment - We should do some refactoring instead of just having the same code in multiple places.

            Thanks zhengchenyu  for patch.

            We can't change the RouterClient.

            -    this.ugi = UserGroupInformation.getCurrentUser();
            +    if (UserGroupInformation.isSecurityEnabled()) {
            +      this.ugi = UserGroupInformation.getLoginUser();
            +    } else {
            +      this.ugi = UserGroupInformation.getCurrentUser();
            +    } 

            It is used in RouterAdmin also and there it should be currentUser() only. Please refer DFSAdmin.java

            surendralilhore Surendra Singh Lilhore added a comment - Thanks zhengchenyu   for patch. We can't change the RouterClient. - this .ugi = UserGroupInformation.getCurrentUser(); + if (UserGroupInformation.isSecurityEnabled()) { + this .ugi = UserGroupInformation.getLoginUser(); + } else { + this .ugi = UserGroupInformation.getCurrentUser(); + } It is used in RouterAdmin also and there it should be currentUser() only. Please refer DFSAdmin.java
            zhengchenyu Chenyu Zheng added a comment -

            surendrasingh, OK, I know your meaning. Maybe need another constructor method.

            zhengchenyu Chenyu Zheng added a comment - surendrasingh , OK, I know your meaning. Maybe need another constructor method.

            Please refer HDFS-15218

            surendralilhore Surendra Singh Lilhore added a comment - Please refer  HDFS-15218
            elgoiri Íñigo Goiri added a comment -

            Should we merge the code change in HDFS-15218 and the unit test here?

            elgoiri Íñigo Goiri added a comment - Should we merge the code change in HDFS-15218 and the unit test here?

            Should we merge the code change in HDFS-15218 and the unit test here?

            I am ok with this.

            surendralilhore Surendra Singh Lilhore added a comment - Should we merge the code change in  HDFS-15218  and the unit test here? I am ok with this.
            elgoiri Íñigo Goiri added a comment -

            zhengchenyu now that HDFS-15218 has been merged, can you update HDFS-15198.003.patch with only the test?

            elgoiri Íñigo Goiri added a comment - zhengchenyu now that HDFS-15218 has been merged, can you update HDFS-15198.003.patch with only the test?
            ayushtkn Ayush Saxena added a comment -

            zhengchenyu plans updating?

            ayushtkn Ayush Saxena added a comment - zhengchenyu plans updating?
            zhengchenyu Chenyu Zheng added a comment -

            Sorry busy for other item, HDFS-15198.004.patch with only uni-test was submit just now. 

            zhengchenyu Chenyu Zheng added a comment - Sorry busy for other item,  HDFS-15198 .004.patch with only uni-test was submit just now. 
            hadoopqa Hadoop QA added a comment -
            -1 overall



            Vote Subsystem Runtime Comment
            0 reexec 1m 25s Docker mode activated.
                  Prechecks
            +1 dupname 0m 0s No case conflicting files found.
            +1 @author 0m 0s The patch does not contain any @author tags.
            +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
                  trunk Compile Tests
            +1 mvninstall 22m 41s trunk passed
            +1 compile 0m 33s trunk passed
            +1 checkstyle 0m 21s trunk passed
            +1 mvnsite 0m 37s trunk passed
            +1 shadedclient 16m 20s branch has no errors when building and testing our client artifacts.
            +1 javadoc 0m 29s trunk passed
            0 spotbugs 1m 11s Used deprecated FindBugs config; considering switching to SpotBugs.
            +1 findbugs 1m 8s trunk passed
                  Patch Compile Tests
            +1 mvninstall 0m 36s the patch passed
            +1 compile 0m 29s the patch passed
            +1 javac 0m 29s the patch passed
            -0 checkstyle 0m 19s hadoop-hdfs-project/hadoop-hdfs-rbf: The patch generated 214 new + 0 unchanged - 0 fixed = 214 total (was 0)
            +1 mvnsite 0m 31s the patch passed
            +1 whitespace 0m 0s The patch has no whitespace issues.
            +1 shadedclient 15m 55s patch has no errors when building and testing our client artifacts.
            +1 javadoc 0m 37s the patch passed
            +1 findbugs 1m 36s the patch passed
                  Other Tests
            -1 unit 9m 47s hadoop-hdfs-rbf in the patch passed.
            +1 asflicense 0m 30s The patch does not generate ASF License warnings.
            75m 19s



            Reason Tests
            Failed junit tests hadoop.hdfs.server.federation.router.TestRouterMountTableCacheRefreshSecure



            Subsystem Report/Notes
            Docker ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/PreCommit-HDFS-Build/29352/artifact/out/Dockerfile
            JIRA Issue HDFS-15198
            JIRA Patch URL https://issues.apache.org/jira/secure/attachment/13003730/HDFS-15198.004.patch
            Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
            uname Linux 9898475c0a93 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
            Build tool maven
            Personality personality/hadoop.sh
            git revision trunk / 96853146337
            Default Java Private Build-1.8.0_252-8u252-b09-1~18.04-b09
            checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/29352/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
            unit https://builds.apache.org/job/PreCommit-HDFS-Build/29352/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
            Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/29352/testReport/
            Max. process+thread count 3224 (vs. ulimit of 5500)
            modules C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf
            Console output https://builds.apache.org/job/PreCommit-HDFS-Build/29352/console
            versions git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1
            Powered by Apache Yetus 0.12.0 https://yetus.apache.org

            This message was automatically generated.

            hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 1m 25s Docker mode activated.       Prechecks +1 dupname 0m 0s No case conflicting files found. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       trunk Compile Tests +1 mvninstall 22m 41s trunk passed +1 compile 0m 33s trunk passed +1 checkstyle 0m 21s trunk passed +1 mvnsite 0m 37s trunk passed +1 shadedclient 16m 20s branch has no errors when building and testing our client artifacts. +1 javadoc 0m 29s trunk passed 0 spotbugs 1m 11s Used deprecated FindBugs config; considering switching to SpotBugs. +1 findbugs 1m 8s trunk passed       Patch Compile Tests +1 mvninstall 0m 36s the patch passed +1 compile 0m 29s the patch passed +1 javac 0m 29s the patch passed -0 checkstyle 0m 19s hadoop-hdfs-project/hadoop-hdfs-rbf: The patch generated 214 new + 0 unchanged - 0 fixed = 214 total (was 0) +1 mvnsite 0m 31s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 shadedclient 15m 55s patch has no errors when building and testing our client artifacts. +1 javadoc 0m 37s the patch passed +1 findbugs 1m 36s the patch passed       Other Tests -1 unit 9m 47s hadoop-hdfs-rbf in the patch passed. +1 asflicense 0m 30s The patch does not generate ASF License warnings. 75m 19s Reason Tests Failed junit tests hadoop.hdfs.server.federation.router.TestRouterMountTableCacheRefreshSecure Subsystem Report/Notes Docker ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/PreCommit-HDFS-Build/29352/artifact/out/Dockerfile JIRA Issue HDFS-15198 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/13003730/HDFS-15198.004.patch Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle uname Linux 9898475c0a93 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality personality/hadoop.sh git revision trunk / 96853146337 Default Java Private Build-1.8.0_252-8u252-b09-1~18.04-b09 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/29352/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs-rbf.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/29352/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/29352/testReport/ Max. process+thread count 3224 (vs. ulimit of 5500) modules C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf Console output https://builds.apache.org/job/PreCommit-HDFS-Build/29352/console versions git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1 Powered by Apache Yetus 0.12.0 https://yetus.apache.org This message was automatically generated.
            elgoiri Íñigo Goiri added a comment -

            Can you fix the checkstyles?
            The spacing is not following the Apache standards, it should be just two spaces.
            Another minor comment, instead of swallowing the exceptions when destroying, just log as error.

            elgoiri Íñigo Goiri added a comment - Can you fix the checkstyles? The spacing is not following the Apache standards, it should be just two spaces. Another minor comment, instead of swallowing the exceptions when destroying, just log as error.
            hadoopqa Hadoop QA added a comment -
            -1 overall



            Vote Subsystem Runtime Comment
            0 reexec 2m 1s Docker mode activated.
                  Prechecks
            +1 dupname 0m 0s No case conflicting files found.
            +1 @author 0m 0s The patch does not contain any @author tags.
            +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
                  trunk Compile Tests
            +1 mvninstall 27m 8s trunk passed
            +1 compile 0m 31s trunk passed
            +1 checkstyle 0m 23s trunk passed
            +1 mvnsite 0m 35s trunk passed
            +1 shadedclient 16m 12s branch has no errors when building and testing our client artifacts.
            +1 javadoc 0m 29s trunk passed
            0 spotbugs 1m 12s Used deprecated FindBugs config; considering switching to SpotBugs.
            +1 findbugs 1m 8s trunk passed
                  Patch Compile Tests
            +1 mvninstall 0m 29s the patch passed
            +1 compile 0m 26s the patch passed
            +1 javac 0m 25s the patch passed
            -0 checkstyle 0m 15s hadoop-hdfs-project/hadoop-hdfs-rbf: The patch generated 5 new + 0 unchanged - 0 fixed = 5 total (was 0)
            +1 mvnsite 0m 28s the patch passed
            +1 whitespace 0m 0s The patch has no whitespace issues.
            +1 shadedclient 15m 17s patch has no errors when building and testing our client artifacts.
            +1 javadoc 0m 26s the patch passed
            +1 findbugs 1m 14s the patch passed
                  Other Tests
            -1 unit 9m 12s hadoop-hdfs-rbf in the patch passed.
            +1 asflicense 0m 28s The patch does not generate ASF License warnings.
            77m 58s



            Reason Tests
            Failed junit tests hadoop.hdfs.server.federation.router.TestRouterMountTableCacheRefreshSecure



            Subsystem Report/Notes
            Docker ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/PreCommit-HDFS-Build/29354/artifact/out/Dockerfile
            JIRA Issue HDFS-15198
            JIRA Patch URL https://issues.apache.org/jira/secure/attachment/13003795/HDFS-15198.005.patch
            Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
            uname Linux 332f505af9a5 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
            Build tool maven
            Personality personality/hadoop.sh
            git revision trunk / 96853146337
            Default Java Private Build-1.8.0_252-8u252-b09-1~18.04-b09
            checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/29354/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
            unit https://builds.apache.org/job/PreCommit-HDFS-Build/29354/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
            Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/29354/testReport/
            Max. process+thread count 2623 (vs. ulimit of 5500)
            modules C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf
            Console output https://builds.apache.org/job/PreCommit-HDFS-Build/29354/console
            versions git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1
            Powered by Apache Yetus 0.12.0 https://yetus.apache.org

            This message was automatically generated.

            hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 2m 1s Docker mode activated.       Prechecks +1 dupname 0m 0s No case conflicting files found. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       trunk Compile Tests +1 mvninstall 27m 8s trunk passed +1 compile 0m 31s trunk passed +1 checkstyle 0m 23s trunk passed +1 mvnsite 0m 35s trunk passed +1 shadedclient 16m 12s branch has no errors when building and testing our client artifacts. +1 javadoc 0m 29s trunk passed 0 spotbugs 1m 12s Used deprecated FindBugs config; considering switching to SpotBugs. +1 findbugs 1m 8s trunk passed       Patch Compile Tests +1 mvninstall 0m 29s the patch passed +1 compile 0m 26s the patch passed +1 javac 0m 25s the patch passed -0 checkstyle 0m 15s hadoop-hdfs-project/hadoop-hdfs-rbf: The patch generated 5 new + 0 unchanged - 0 fixed = 5 total (was 0) +1 mvnsite 0m 28s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 shadedclient 15m 17s patch has no errors when building and testing our client artifacts. +1 javadoc 0m 26s the patch passed +1 findbugs 1m 14s the patch passed       Other Tests -1 unit 9m 12s hadoop-hdfs-rbf in the patch passed. +1 asflicense 0m 28s The patch does not generate ASF License warnings. 77m 58s Reason Tests Failed junit tests hadoop.hdfs.server.federation.router.TestRouterMountTableCacheRefreshSecure Subsystem Report/Notes Docker ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/PreCommit-HDFS-Build/29354/artifact/out/Dockerfile JIRA Issue HDFS-15198 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/13003795/HDFS-15198.005.patch Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle uname Linux 332f505af9a5 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality personality/hadoop.sh git revision trunk / 96853146337 Default Java Private Build-1.8.0_252-8u252-b09-1~18.04-b09 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/29354/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs-rbf.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/29354/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/29354/testReport/ Max. process+thread count 2623 (vs. ulimit of 5500) modules C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf Console output https://builds.apache.org/job/PreCommit-HDFS-Build/29354/console versions git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1 Powered by Apache Yetus 0.12.0 https://yetus.apache.org This message was automatically generated.
            elgoiri Íñigo Goiri added a comment -

            Thanks for the update, there are a few checkstyle left which we can fix.
            There's also the failed TestRouterMountTableCacheRefreshSecure which seems to point to the cluster not starting (which BTW, 60 seconds looks like a long time).
            Other minor comments:

            • Let's use the logger format {}, with things like: LOG.error("Found error when destroy, caused by: {}", e.getMessage());.
            • Let's extract things like line 124, 149, 251, 284 (actually this method can be split).
            elgoiri Íñigo Goiri added a comment - Thanks for the update, there are a few checkstyle left which we can fix. There's also the failed TestRouterMountTableCacheRefreshSecure which seems to point to the cluster not starting (which BTW, 60 seconds looks like a long time). Other minor comments: Let's use the logger format {}, with things like: LOG.error("Found error when destroy, caused by: {}", e.getMessage()); . Let's extract things like line 124, 149, 251, 284 (actually this method can be split).
            hadoopqa Hadoop QA added a comment -
            +1 overall



            Vote Subsystem Runtime Comment
            0 reexec 0m 42s Docker mode activated.
                  Prechecks
            +1 dupname 0m 0s No case conflicting files found.
            +1 @author 0m 0s The patch does not contain any @author tags.
            +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
                  trunk Compile Tests
            +1 mvninstall 18m 46s trunk passed
            +1 compile 0m 37s trunk passed
            +1 checkstyle 0m 25s trunk passed
            +1 mvnsite 0m 39s trunk passed
            +1 shadedclient 15m 5s branch has no errors when building and testing our client artifacts.
            +1 javadoc 0m 34s trunk passed
            0 spotbugs 1m 9s Used deprecated FindBugs config; considering switching to SpotBugs.
            +1 findbugs 1m 6s trunk passed
                  Patch Compile Tests
            +1 mvninstall 0m 32s the patch passed
            +1 compile 0m 28s the patch passed
            +1 javac 0m 28s the patch passed
            +1 checkstyle 0m 17s the patch passed
            +1 mvnsite 0m 30s the patch passed
            +1 whitespace 0m 0s The patch has no whitespace issues.
            +1 shadedclient 13m 53s patch has no errors when building and testing our client artifacts.
            +1 javadoc 0m 31s the patch passed
            +1 findbugs 1m 11s the patch passed
                  Other Tests
            +1 unit 8m 31s hadoop-hdfs-rbf in the patch passed.
            +1 asflicense 0m 33s The patch does not generate ASF License warnings.
            65m 39s



            Subsystem Report/Notes
            Docker ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/PreCommit-HDFS-Build/29357/artifact/out/Dockerfile
            JIRA Issue HDFS-15198
            JIRA Patch URL https://issues.apache.org/jira/secure/attachment/13003853/HDFS-15198.006.patch
            Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
            uname Linux ce42292711ce 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
            Build tool maven
            Personality personality/hadoop.sh
            git revision trunk / 6e04b00df1b
            Default Java Private Build-1.8.0_252-8u252-b09-1~18.04-b09
            Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/29357/testReport/
            Max. process+thread count 2940 (vs. ulimit of 5500)
            modules C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf
            Console output https://builds.apache.org/job/PreCommit-HDFS-Build/29357/console
            versions git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1
            Powered by Apache Yetus 0.12.0 https://yetus.apache.org

            This message was automatically generated.

            hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 42s Docker mode activated.       Prechecks +1 dupname 0m 0s No case conflicting files found. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.       trunk Compile Tests +1 mvninstall 18m 46s trunk passed +1 compile 0m 37s trunk passed +1 checkstyle 0m 25s trunk passed +1 mvnsite 0m 39s trunk passed +1 shadedclient 15m 5s branch has no errors when building and testing our client artifacts. +1 javadoc 0m 34s trunk passed 0 spotbugs 1m 9s Used deprecated FindBugs config; considering switching to SpotBugs. +1 findbugs 1m 6s trunk passed       Patch Compile Tests +1 mvninstall 0m 32s the patch passed +1 compile 0m 28s the patch passed +1 javac 0m 28s the patch passed +1 checkstyle 0m 17s the patch passed +1 mvnsite 0m 30s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 shadedclient 13m 53s patch has no errors when building and testing our client artifacts. +1 javadoc 0m 31s the patch passed +1 findbugs 1m 11s the patch passed       Other Tests +1 unit 8m 31s hadoop-hdfs-rbf in the patch passed. +1 asflicense 0m 33s The patch does not generate ASF License warnings. 65m 39s Subsystem Report/Notes Docker ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/PreCommit-HDFS-Build/29357/artifact/out/Dockerfile JIRA Issue HDFS-15198 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/13003853/HDFS-15198.006.patch Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle uname Linux ce42292711ce 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality personality/hadoop.sh git revision trunk / 6e04b00df1b Default Java Private Build-1.8.0_252-8u252-b09-1~18.04-b09 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/29357/testReport/ Max. process+thread count 2940 (vs. ulimit of 5500) modules C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf Console output https://builds.apache.org/job/PreCommit-HDFS-Build/29357/console versions git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1 Powered by Apache Yetus 0.12.0 https://yetus.apache.org This message was automatically generated.
            ayushtkn Ayush Saxena added a comment -

            Thanx zhengchenyu for the patch.
            Why you need to change FederationTestUtils, is the time limit creating problem for this test?

            ayushtkn Ayush Saxena added a comment - Thanx zhengchenyu for the patch. Why you need to change FederationTestUtils , is the time limit creating problem for this test?
            zhengchenyu Chenyu Zheng added a comment -

            ayushtkn Yes, uni-test may fail when timeout is 20. When increase to 60, uni-test succeed in all trials.

            zhengchenyu Chenyu Zheng added a comment - ayushtkn  Yes, uni-test may fail when timeout is 20. When increase to 60, uni-test succeed in all trials.
            ayushtkn Ayush Saxena added a comment -

            Thanx zhengchenyu for confirming, changes looks good, have triggered build again.
            if no complains, will push by EOD

            ayushtkn Ayush Saxena added a comment - Thanx zhengchenyu for confirming, changes looks good, have triggered build again. if no complains, will push by EOD
            zhengchenyu Chenyu Zheng added a comment -

            ayushtkn, Okay, I have no complains. I think there is no need to change. 

            zhengchenyu Chenyu Zheng added a comment - ayushtkn , Okay, I have no complains. I think there is no need to change. 
            hadoopqa Hadoop QA added a comment -
            -1 overall



            Vote Subsystem Runtime Comment
            0 reexec 1m 55s Docker mode activated.
                  Prechecks
            +1 dupname 0m 0s No case conflicting files found.
            +1 @author 0m 0s The patch does not contain any @author tags.
            +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
                  trunk Compile Tests
            +1 mvninstall 22m 59s trunk passed
            +1 compile 0m 32s trunk passed
            +1 checkstyle 0m 20s trunk passed
            +1 mvnsite 0m 37s trunk passed
            +1 shadedclient 16m 35s branch has no errors when building and testing our client artifacts.
            +1 javadoc 0m 32s trunk passed
            0 spotbugs 1m 21s Used deprecated FindBugs config; considering switching to SpotBugs.
            +1 findbugs 1m 19s trunk passed
                  Patch Compile Tests
            +1 mvninstall 0m 36s the patch passed
            +1 compile 0m 29s the patch passed
            +1 javac 0m 29s the patch passed
            +1 checkstyle 0m 16s the patch passed
            +1 mvnsite 0m 35s the patch passed
            +1 whitespace 0m 0s The patch has no whitespace issues.
            +1 shadedclient 15m 47s patch has no errors when building and testing our client artifacts.
            +1 javadoc 0m 29s the patch passed
            +1 findbugs 1m 28s the patch passed
                  Other Tests
            -1 unit 9m 38s hadoop-hdfs-rbf in the patch passed.
            +1 asflicense 0m 30s The patch does not generate ASF License warnings.
            75m 50s



            Reason Tests
            Failed junit tests hadoop.hdfs.server.federation.router.TestRouterQuota
              hadoop.hdfs.server.federation.router.TestRouterRpc



            Subsystem Report/Notes
            Docker ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/PreCommit-HDFS-Build/29526/artifact/out/Dockerfile
            JIRA Issue HDFS-15198
            JIRA Patch URL https://issues.apache.org/jira/secure/attachment/13003853/HDFS-15198.006.patch
            Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
            uname Linux d53566bfe01b 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
            Build tool maven
            Personality personality/hadoop.sh
            git revision trunk / cc71d50b219
            Default Java Private Build-1.8.0_252-8u252-b09-1~18.04-b09
            unit https://builds.apache.org/job/PreCommit-HDFS-Build/29526/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
            Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/29526/testReport/
            Max. process+thread count 3110 (vs. ulimit of 5500)
            modules C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf
            Console output https://builds.apache.org/job/PreCommit-HDFS-Build/29526/console
            versions git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1
            Powered by Apache Yetus 0.12.0 https://yetus.apache.org

            This message was automatically generated.

            hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 1m 55s Docker mode activated.       Prechecks +1 dupname 0m 0s No case conflicting files found. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.       trunk Compile Tests +1 mvninstall 22m 59s trunk passed +1 compile 0m 32s trunk passed +1 checkstyle 0m 20s trunk passed +1 mvnsite 0m 37s trunk passed +1 shadedclient 16m 35s branch has no errors when building and testing our client artifacts. +1 javadoc 0m 32s trunk passed 0 spotbugs 1m 21s Used deprecated FindBugs config; considering switching to SpotBugs. +1 findbugs 1m 19s trunk passed       Patch Compile Tests +1 mvninstall 0m 36s the patch passed +1 compile 0m 29s the patch passed +1 javac 0m 29s the patch passed +1 checkstyle 0m 16s the patch passed +1 mvnsite 0m 35s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 shadedclient 15m 47s patch has no errors when building and testing our client artifacts. +1 javadoc 0m 29s the patch passed +1 findbugs 1m 28s the patch passed       Other Tests -1 unit 9m 38s hadoop-hdfs-rbf in the patch passed. +1 asflicense 0m 30s The patch does not generate ASF License warnings. 75m 50s Reason Tests Failed junit tests hadoop.hdfs.server.federation.router.TestRouterQuota   hadoop.hdfs.server.federation.router.TestRouterRpc Subsystem Report/Notes Docker ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/PreCommit-HDFS-Build/29526/artifact/out/Dockerfile JIRA Issue HDFS-15198 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/13003853/HDFS-15198.006.patch Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle uname Linux d53566bfe01b 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality personality/hadoop.sh git revision trunk / cc71d50b219 Default Java Private Build-1.8.0_252-8u252-b09-1~18.04-b09 unit https://builds.apache.org/job/PreCommit-HDFS-Build/29526/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/29526/testReport/ Max. process+thread count 3110 (vs. ulimit of 5500) modules C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf Console output https://builds.apache.org/job/PreCommit-HDFS-Build/29526/console versions git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1 Powered by Apache Yetus 0.12.0 https://yetus.apache.org This message was automatically generated.
            hadoopqa Hadoop QA added a comment -
            +1 overall



            Vote Subsystem Runtime Comment
            0 reexec 1m 49s Docker mode activated.
                  Prechecks
            +1 dupname 0m 0s No case conflicting files found.
            +1 @author 0m 0s The patch does not contain any @author tags.
            +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
                  trunk Compile Tests
            +1 mvninstall 27m 25s trunk passed
            +1 compile 0m 37s trunk passed
            +1 checkstyle 0m 24s trunk passed
            +1 mvnsite 0m 40s trunk passed
            +1 shadedclient 18m 52s branch has no errors when building and testing our client artifacts.
            +1 javadoc 0m 36s trunk passed
            0 spotbugs 1m 34s Used deprecated FindBugs config; considering switching to SpotBugs.
            +1 findbugs 1m 32s trunk passed
                  Patch Compile Tests
            +1 mvninstall 0m 37s the patch passed
            +1 compile 0m 31s the patch passed
            +1 javac 0m 31s the patch passed
            +1 checkstyle 0m 18s the patch passed
            +1 mvnsite 0m 37s the patch passed
            +1 whitespace 0m 0s The patch has no whitespace issues.
            +1 shadedclient 17m 53s patch has no errors when building and testing our client artifacts.
            +1 javadoc 0m 35s the patch passed
            +1 findbugs 1m 32s the patch passed
                  Other Tests
            +1 unit 10m 49s hadoop-hdfs-rbf in the patch passed.
            +1 asflicense 0m 38s The patch does not generate ASF License warnings.
            86m 55s



            Subsystem Report/Notes
            Docker ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/PreCommit-HDFS-Build/29527/artifact/out/Dockerfile
            JIRA Issue HDFS-15198
            JIRA Patch URL https://issues.apache.org/jira/secure/attachment/13003853/HDFS-15198.006.patch
            Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
            uname Linux 1ef748e09195 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
            Build tool maven
            Personality personality/hadoop.sh
            git revision trunk / 2ba44a73bf2
            Default Java Private Build-1.8.0_252-8u252-b09-1~18.04-b09
            Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/29527/testReport/
            Max. process+thread count 3137 (vs. ulimit of 5500)
            modules C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf
            Console output https://builds.apache.org/job/PreCommit-HDFS-Build/29527/console
            versions git=2.17.1 maven=3.6.0 findbugs=4.0.6
            Powered by Apache Yetus 0.12.0 https://yetus.apache.org

            This message was automatically generated.

            hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 1m 49s Docker mode activated.       Prechecks +1 dupname 0m 0s No case conflicting files found. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.       trunk Compile Tests +1 mvninstall 27m 25s trunk passed +1 compile 0m 37s trunk passed +1 checkstyle 0m 24s trunk passed +1 mvnsite 0m 40s trunk passed +1 shadedclient 18m 52s branch has no errors when building and testing our client artifacts. +1 javadoc 0m 36s trunk passed 0 spotbugs 1m 34s Used deprecated FindBugs config; considering switching to SpotBugs. +1 findbugs 1m 32s trunk passed       Patch Compile Tests +1 mvninstall 0m 37s the patch passed +1 compile 0m 31s the patch passed +1 javac 0m 31s the patch passed +1 checkstyle 0m 18s the patch passed +1 mvnsite 0m 37s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 shadedclient 17m 53s patch has no errors when building and testing our client artifacts. +1 javadoc 0m 35s the patch passed +1 findbugs 1m 32s the patch passed       Other Tests +1 unit 10m 49s hadoop-hdfs-rbf in the patch passed. +1 asflicense 0m 38s The patch does not generate ASF License warnings. 86m 55s Subsystem Report/Notes Docker ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/PreCommit-HDFS-Build/29527/artifact/out/Dockerfile JIRA Issue HDFS-15198 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/13003853/HDFS-15198.006.patch Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle uname Linux 1ef748e09195 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality personality/hadoop.sh git revision trunk / 2ba44a73bf2 Default Java Private Build-1.8.0_252-8u252-b09-1~18.04-b09 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/29527/testReport/ Max. process+thread count 3137 (vs. ulimit of 5500) modules C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf Console output https://builds.apache.org/job/PreCommit-HDFS-Build/29527/console versions git=2.17.1 maven=3.6.0 findbugs=4.0.6 Powered by Apache Yetus 0.12.0 https://yetus.apache.org This message was automatically generated.
            ayushtkn Ayush Saxena added a comment -

            Well by complains, I meant complains from jenkins. Well glad to know you too don't have any complains.

            v006 LGTM +1

            ayushtkn Ayush Saxena added a comment - Well by complains, I meant complains from jenkins. Well glad to know you too don't have any complains. v006 LGTM +1
            ayushtkn Ayush Saxena added a comment -

            Committed to trunk.

            Thanx zhengchenyu for the contribution and elgoiri for the review!!!

            ayushtkn Ayush Saxena added a comment - Committed to trunk. Thanx zhengchenyu for the contribution and elgoiri for the review!!!
            hudson Hudson added a comment -

            SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #18448 (See https://builds.apache.org/job/Hadoop-trunk-Commit/18448/)
            HDFS-15198. RBF: Add test for MountTableRefresherService failed to (ayushsaxena: rev 8a9a674ef10a951c073ef17ba6db1ff07cff52cd)

            • (edit) hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/FederationTestUtils.java
            • (add) hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterMountTableCacheRefreshSecure.java
            hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #18448 (See https://builds.apache.org/job/Hadoop-trunk-Commit/18448/ ) HDFS-15198 . RBF: Add test for MountTableRefresherService failed to (ayushsaxena: rev 8a9a674ef10a951c073ef17ba6db1ff07cff52cd) (edit) hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/FederationTestUtils.java (add) hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterMountTableCacheRefreshSecure.java

            People

              zhengchenyu Chenyu Zheng
              zhengchenyu Chenyu Zheng
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - 48h
                  48h
                  Remaining:
                  Remaining Estimate - 48h
                  48h
                  Logged:
                  Time Spent - Not Specified
                  Not Specified