[HDFS-15161] When evictableMmapped or evictable size is zero, do not throw NoSuchElementException in ShortCircuitCache#close()

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.3.0, 2.9.3, 3.1.4, 3.2.2, 2.10.1
• Hadoop Flags: Reviewed
• Assignee: Lisheng Sun
• Reporter: Lisheng Sun
• Created: 11/Feb/20 08:04
• Updated: 12/Feb/20 15:29
• Resolved: 12/Feb/20 15:15

Description

detail see HDFS-14541

/**
 * Close the cache and free all associated resources.
 */
@Override
public void close() {
  try {
    lock.lock();
    if (closed) return;
    closed = true;
    LOG.info(this + ": closing");
    maxNonMmappedEvictableLifespanMs = 0;
    maxEvictableMmapedSize = 0;
    // Close and join cacheCleaner thread.
    IOUtilsClient.cleanupWithLogger(LOG, cacheCleaner);
    // Purge all replicas.
    while (true) {
      Object eldestKey;
      try {
        eldestKey = evictable.firstKey();
      } catch (NoSuchElementException e) {
        break;
      }
      purge((ShortCircuitReplica)evictable.get(eldestKey));
    }
    while (true) {
      Object eldestKey;
      try {
        eldestKey = evictableMmapped.firstKey();
      } catch (NoSuchElementException e) {
        break;
      }
      purge((ShortCircuitReplica)evictableMmapped.get(eldestKey));
    }
  } finally {
    lock.unlock();
  }

 

Issue Links

• relates to: HDFS-14541 When evictableMmapped or evictable size is zero, do not throw NoSuchElementException