Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-1507

TestAbandonBlock should abandon a block

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.22.0, 0.23.0
    • Fix Version/s: 0.22.0
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      TestAbandonBlock as written just tests that if one client tries to abandon another it will fail because the new client doesn't have a lease on the other client's file, which doesn't cover the block abandonement code path.

        Issue Links

          Activity

          Eli Collins created issue -
          Hide
          Eli Collins added a comment -

          Patch attached. Covers successful block abandonment. Also converts the test to junit4 style.

          Show
          Eli Collins added a comment - Patch attached. Covers successful block abandonment. Also converts the test to junit4 style.
          Eli Collins made changes -
          Field Original Value New Value
          Attachment hdfs-1507-1.patch [ 12459844 ]
          Eli Collins made changes -
          Link This issue blocks HDFS-1487 [ HDFS-1487 ]
          Hide
          Eli Collins added a comment -

          Release audit warnings are unrelated. Just modified TestAbandonBlock so I just ran it.

               [exec] 
               [exec] -1 overall.  
               [exec] 
               [exec]     +1 @author.  The patch does not contain any @author tags.
               [exec] 
               [exec]     +1 tests included.  The patch appears to include 3 new or modified tests.
               [exec] 
               [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
               [exec] 
               [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
               [exec] 
               [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
               [exec] 
               [exec]     -1 release audit.  The applied patch generated 103 release audit warnings (more than the trunk's current 1 warnings).
               [exec] 
               [exec]     +1 system test framework.  The patch passed system test framework compile.
               [exec] 
          
          Show
          Eli Collins added a comment - Release audit warnings are unrelated. Just modified TestAbandonBlock so I just ran it. [exec] [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 3 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] -1 release audit. The applied patch generated 103 release audit warnings (more than the trunk's current 1 warnings). [exec] [exec] +1 system test framework. The patch passed system test framework compile. [exec]
          Hide
          Konstantin Boudnik added a comment -

          From an offline chat with Eli I had confirmed that this is a positive expecting not to exception after the last line's execution.
          +1 patch looks good.

          Show
          Konstantin Boudnik added a comment - From an offline chat with Eli I had confirmed that this is a positive expecting not to exception after the last line's execution. +1 patch looks good.
          Hide
          Eli Collins added a comment -

          Thanks Cos. I've committed this. Will merge to 22 when the branch has been created.

          Show
          Eli Collins added a comment - Thanks Cos. I've committed this. Will merge to 22 when the branch has been created.
          Hide
          Eli Collins added a comment -

          Committed to branch 22.

          Show
          Eli Collins added a comment - Committed to branch 22.
          Eli Collins made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Hadoop Flags [Reviewed]
          Fix Version/s 0.23.0 [ 12315571 ]
          Resolution Fixed [ 1 ]

            People

            • Assignee:
              Eli Collins
              Reporter:
              Eli Collins
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development