[HDFS-15069] DecommissionMonitor-0 thread will block forever while its timer task scheduled encountered any unchecked exceptions.

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 3.1.3
• Component/s: namenode
• Assignee: Xudong Cao Assign to me
• Reporter: Xudong Cao
• Created: 18/Dec/19 08:32
• Updated: 19/Dec/19 01:37
• Resolved: 19/Dec/19 01:36

Description

More than once, we have observed that during decommissioning of a large number of DNs, the thread DecommissionMonitor-0 will stop scheduling, blocking for a long time, and there will be no exception logs or notifications at all.

e.g. Recently, we are decommissioning 65 DNs at the same time, each DN about 10TB, and the DecommissionMonitor-0 thread blocked for about 15 days.

The stack of DecommissionMonitor-0 looks like this:

1. stack on 2019.12.17 16:12
2. stack on 2019.12.17 16:42

It can be seen that during half an hour, this thread has not been scheduled at all, its Waited count has not changed.

We think the cause of the problem is:

1. The DecommissionMonitor task submitted by NameNode encounters an unchecked exception during its running , and then this task will be never executed again.
2. But NameNode does not care about the ScheduledFuture of this task, and never calls ScheduledFuture.get(), so the unchecked exception thrown by the task above will always be placed there, no one knows.

After that, the subsequent phenomenon is:

1. The ScheduledExecutorService thread DecommissionMonitor-0 will block forever in ThreadPoolExecutor.getTask().
2. The previously submitted task DecommissionMonitor will be never executed again.
3. No logs or notifications can let us know exactly what had happened.

Possible solutions:

1. Do not use thread pool to execute decommission monitor task, alternatively we can introduce a separate thread to do this, just like HeartbeatManager, ReplicationMonitor, LeaseManager, BlockReportThread, and so on.

       OR

       2. Catch all exceptions in decommission monitor task's run() method, so it does not throw any exceptions.

I prefer the second option.

 

Issue Links

• duplicates: HDFS-12703 Exceptions are fatal to decommissioning monitor