[HDFS-14993] checkDiskError doesn't work during datanode startup

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.3.0, 3.1.4, 3.2.2
• Component/s: datanode
• Hadoop Flags: Reviewed
• Assignee: Yang Yun
• Reporter: Yang Yun
• Created: 19/Nov/19 08:15
• Updated: 28/Jan/20 17:53
• Resolved: 28/Jan/20 17:41

Description

the function checkDiskError() is called before addBlockPool, but list bpSlices is empty this time. So the function check() in FsVolumeImpl.java does nothing.

@Override
public VolumeCheckResult check(VolumeCheckContext ignored)
throws DiskErrorException {
// TODO:FEDERATION valid synchronization
for (BlockPoolSlice s : bpSlices.values())

{ s.checkDirs(); }

return VolumeCheckResult.HEALTHY;
}